Skip to content

feat: move to vcpkg#161

Open
romeoahmed wants to merge 2 commits intoModOrganizer2:masterfrom
romeoahmed:feat/vcpkg
Open

feat: move to vcpkg#161
romeoahmed wants to merge 2 commits intoModOrganizer2:masterfrom
romeoahmed:feat/vcpkg

Conversation

@romeoahmed
Copy link
Contributor

@romeoahmed romeoahmed commented Feb 2, 2026 •
edited
Loading

  • Libraries (e.g. libcurl) from third-party are now managed by vcpkg.

  • Let libcurl use zlib-ng.

  • Added instructions for setting up vcpkg.

@romeoahmed romeoahmed force-pushed the feat/vcpkg branch 7 times, most recently from 4b69b93 to d8f9c4e Compare February 3, 2026 02:53
@Holt59
Copy link
Member

Holt59 commented Feb 3, 2026

Thanks for the PR, a few comment:

@romeoahmed
Copy link
Contributor Author

romeoahmed commented Feb 3, 2026 •
edited
Loading

  1. custom-ports is for overriding zlib, actually linking zlib-ng.

  2. custom-triplets is for setting zlib-ng to zlib compatibility mode and can be used in the future to disable implicit nlohmann/json conversions.

  3. I will try to look into adding VCPKG caching, and I'm also trying to add CMakePresets.json.

@romeoahmed
Copy link
Contributor Author

romeoahmed commented Feb 3, 2026 •
edited
Loading

  • vcpkg caching has now been added.
  • CMakePresets.json replaces most of the operations in bootstrap.ps1.
  • The implicit conversion issue when using nlohmann/json in pr.cpp has also been fixed.
  • imagehelp.h has been replaced with dbghelp.h.
  • _WIN32_WINNT=0x0A00 and NTDDI_VERSION=0x0A000007 are now specified, requiring minimum system support of Windows 10 1903 "19H1".

@romeoahmed romeoahmed force-pushed the feat/vcpkg branch 5 times, most recently from 35b0e51 to 8d7aaf0 Compare February 3, 2026 11:45
Holt59
Holt59 reviewed Feb 5, 2026
View reviewed changes
src/CMakeLists.txt
source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}
PREFIX src
FILES ${source_files} ${header_files})
set_property(DIRECTORY ${PROJECT_SOURCE_DIR} PROPERTY VS_STARTUP_PROJECT mob)
Copy link
Member

@Holt59 Holt59 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this was removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Holt59 Holt59 Holt59 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romeoahmed @Holt59