➕ [Fix] Add tensorboard to temporarily fix Quite issue #218#219
Open
sam31046 wants to merge 1 commit intoMultimediaTechLab:mainfrom
Open
➕ [Fix] Add tensorboard to temporarily fix Quite issue #218#219sam31046 wants to merge 1 commit intoMultimediaTechLab:mainfrom
sam31046 wants to merge 1 commit intoMultimediaTechLab:mainfrom
Conversation
…Lab#218 This PR temporarily fix MultimediaTechLab#218 by adding `tensorboard` in `requirements.txt`
Member
|
Hi, Thanks for your PR! I believe tensorboard is already included in the requirements-dev.txt file. As for the solution, I think a clean fix would be to move the check for cfg.use_tensorboard inside logging_utils.py, placing it before the if quiet: return shortcut. That way, we ensure the logger setup logic executes as expected when tensorboard is enabled. Let me know what you think! Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR temporarily fix #218 by adding
tensorboardinrequirements.txt