fixed build system not returning docker command

[Cynosure-null]

Changes

ner build and ner test now return the exit code of the docker command as opposed to just 0

Notes

The rationale for this change was to allow command chaning such as ner build && ner flash

Test Cases

• ner build on a functional Cerberus-2.0 returns 0
• ner build on a broken Cerberus-2.0 returns the error code of the compiler

To Do

This is a minor change that shouldn't require continuing effort

Checklist

• No merge conflicts
• All checks passing
• Remove any non-applicable sections of this template
• Assign the PR to yourself
• Request reviewers & ping on Slack
• PR is linked to the ticket (fill in the closes line below)

Closes #364

[Copilot]

Pull request overview

Updates the ner build wrapper so failures inside Docker propagate back to the user’s shell, enabling reliable command chaining (e.g., ner build && ner flash) and addressing Issue #364.

Changes:

• Capture docker compose run exit codes during ner build and exit non-zero on failure.
• Refactor run_command() / run_command_docker() to return command return codes (intended behavior).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The clean command uses ; between cmake --build ... clean and find ... rm -rf .... When run via sh -c, the overall return code will be from the last command (find), which can mask a failing cmake clean and defeat the goal of propagating build errors. Use && (or otherwise preserve the first command’s exit code) so failures reliably propagate.

Suggested change

	returncode = run_command_docker('cmake --build build --target clean ; find . -type d -name "build" -exec rm -rf {} +')
	returncode = run_command_docker('cmake --build build --target clean && find . -type d -name "build" -exec rm -rf {} +')

[Copilot]

returncode here can currently be None because run_command() doesn’t return 0 on success in all paths (e.g., stream_output=True or commands with empty stdout like chmod). Comparing None != 0 will be true and will trigger sys.exit(None) (exit 0) early, skipping subsequent steps (e.g., chmod/fix_compile_commands). Fix run_command() to always return an int (0 on success) so these checks behave correctly.

[Copilot]

run_command() is annotated to return int, but it returns None on success in multiple cases: (1) stream_output=True with a zero exit status, and (2) stream_output=False when the command succeeds but produces no stdout. This breaks callers that rely on the return code (now including build). Ensure the function returns 0 on all successful paths and the actual non-zero code on failure.

Suggested change

	else:
	try:
	result = subprocess.run(command, check=True, capture_output=True, text=True)
	if result.stdout and result.stdout.strip(): # Only print if stdout is not empty or just whitespace
	print(result.stdout)
	return 0 # Code should be zero if it reaches this point
	# Successful execution with zero exit status
	return 0
	else:
	try:
	result = subprocess.run(command, check=True, capture_output=True, text=True)
	if result.stdout and result.stdout.strip(): # Only print if stdout is not empty or just whitespace
	print(result.stdout)
	# Command succeeded (check=True did not raise), so return success code
	return 0 # Code should be zero if it reaches this point

[Copilot]

PR description mentions ner test returning the Docker command exit code, but only build() checks and exits based on run_command_docker()’s return value. Since Typer/Click ignores a command function’s return value, test() will still exit 0 unless it explicitly raises typer.Exit(code=...) / sys.exit(...) on non-zero return codes. Update test() accordingly (including the --clean path if desired).