Skip to content

[17.0][IMP]queue_job: only subscribe job creator if indicated via boolean method #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GuillemCForgeFlow wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][IMP]queue_job: only subscribe job creator if indicated via boolean method #865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion queue_job/models/queue_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,11 @@ def _message_post_on_failure(self):
# at every job creation
domain = self._subscribe_users_domain()
base_users = self.env["res.users"].search(domain)
suscribe_job_creator = self._subscribe_job_creator()
for record in self:
users = base_users | record.user_id
users = base_users
if suscribe_job_creator:
users |= record.user_id
record.message_subscribe(partner_ids=users.mapped("partner_id").ids)
msg = record._message_failed_job()
if msg:
Expand All @@ -368,6 +371,14 @@ def _subscribe_users_domain(self):
domain.append(("company_id", "in", companies.ids))
return domain

@api.model
def _subscribe_job_creator(self):
"""
Whether the user that created the job should be subscribed to the job,
in addition to users determined by `_subscribe_users_domain`
"""
return True

def _message_failed_job(self):
"""Return a message which will be posted on the job when it is failed.

Expand Down