[18.0] queue_job: refactor job acquisition #866
+109
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @guewen, |
sbidoul
force-pushed
the
18.0-refactor-job-acquisition-sbi
branch
2 times, most recently
from
265b06e to
8d0b9c9
Compare
sbidoul
changed the title
sbidoul
force-pushed
the
18.0-refactor-job-acquisition-sbi
branch
2 times, most recently
from
eff0043 to
d6c907a
Compare
In this commit we cleanly separate the job acquisition (i.e. verifying the job is in the exepected state, marking it started and locking it) from job execution. We also avoid trying to start the job if it is already locked by using SKIP LOCKED and exiting early. Indeed in such situations the job is likely already being handled by another worker so there is no point trying to start it, so we exit early and let it be handled either by the other worker or the dead job requeuer.
sbidoul
force-pushed
the
18.0-refactor-job-acquisition-sbi
branch
from
d6c907a to
367ab80
Compare
sbidoul
commented
Jan 2, 2026
| " to make this tests work", | ||
| ) | ||
|
|
||
| return job |
Member
Author
|
This is ready to review. It can be tested with a small number of workers and a root channel capacity greater than the number of workers and test jobs of duration >= 10 sec. If the test graph has enough parallelism, you will see warnings about dead jobs being requeued (the jobs in state enqueued that are not picked up by workers in due time), but each job should execute only once. Example: The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we cleanly separate the job acquisition (i.e. verifying the job is in the exepected state, marking it started and locking it) from job execution.
We also avoid trying to start the job if it is already locked by using SKIP LOCKED and exiting early. Indeed, in such situations, the job is likely already being handled by another worker so there is no point trying to start it, so we exit early and let it be handled either by the other worker or the dead job requeuer.
Following-up on #859 (comment)
maybe fixes #858