[ADD] base_web_hook: Create abstract web hooks by lasley · Pull Request #4 · OCA/webhook

lasley · 2017-10-10T21:13:06Z

Create a module to allow for the receipt of web hooks in an abstract fashion

Depends:

[ADD] base_json_request: Module to allow standard JSON requests #3

This is a PoC.

* Create a module that circumvents the JSON-RPC requirement for all requests with application/json

* Create a module to allow for the receipt of web hooks in an abstract fashion

lasley · 2017-10-11T21:08:23Z

base_web_hook/controllers/main.py

+
+    @http.route(
+        ['/base_web_hook/<string:slug>'],
+        type='json',


Hmmmm maybe should be an HTTP receiver as well

lasley · 2017-10-11T23:55:08Z

Alright this is implemented in a connector, so it's less rough around the edges now. We've still got some testing to do on the connector, and another one to implement, so I would assume there's still work to come here.

This is an implementation example

lasley · 2017-10-13T15:54:40Z

base_web_hook/models/web_hook.py

+    _name = 'web.hook'
+    _description = 'Web Hook'
+
+    name = fields.Char(


Add UNIQUE(name)

lasley · 2017-10-17T23:42:29Z

Alright I've now added a Request Bin hook type, which simply catches and saves inbound requests. This is a useful tool for testing web hooks as an administrator, but will also help me test the module in an automated fashion.

hbrunn · 2017-11-28T17:48:48Z

late to the party, are you aware of https://github.com/OCA/server-tools/tree/10.0/webhook ?
(I do have a couple of things I'd like to change...)

lasley · 2017-11-28T18:06:10Z

Not aware at all. How did you conquer the receipt of JSON?

hbrunn · 2017-11-28T18:10:54Z

I didn't conquer anything there, didn't even use the module. But I read it yesterday and decided I can't use it for what I had in mind.

hbrunn · 2017-11-28T18:13:22Z

looks straightforward enough: https://github.com/OCA/server-tools/blob/10.0/webhook/controllers/main.py#L17

lasley · 2017-11-28T18:14:36Z

I'm looking at the module, and it definitely does not work as intended in most cases. The route is using type='json', which means that the hook must be an RPC formatted request. See odoo/odoo#7766

I would propose this module as a direct successor to the other TBH. There are significantly more features here, such as the ability to receive non-JSON requests & session authenticated hooks.

lasley · 2017-11-28T18:21:54Z

@moylop260 - your module https://github.com/OCA/server-tools/tree/10.0/webhook has instructions specifically for Github web hooks, but odoo/odoo#7766 alludes to the fact that this does not actual work. Can you confirm OCA/server-tools/webhook does work for any inbound JSON webhook without sitting a proxy in front of the Odoo server?

pntabuye

tested on Odoo 10e and not conclusive. The non JSON-RPC json does not raise a BadRequest error from werkzeug.

pntabuye · 2018-05-08T08:01:48Z

base_json_request/http.py

+        old_init(self, *args)
+    except BadRequest as e:
+        try:
+            args = self.httprequest.args


AttributeError: 'JsonRequest' object has no attribute 'httprequest'

mlaitinen · 2018-08-08T14:23:07Z

base_json_request/README.rst

+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/210/10.0
+
+Bug Tracker


Please add a usage section on how to use this module

mlaitinen · 2018-08-08T14:23:30Z

base_web_hook/README.rst

+* Security is too lax; public can read too much. Maybe should also add a group for hooks..
+* Buffer length should be checked before ``httprequest.get_data`` calls
+
+Bug Tracker


Please add a usage section on how to use this module

gurneyalex · 2024-07-29T13:34:48Z

sale, old odoo running on python 2 -> closing

lasley added 2 commits October 10, 2017 12:15

[ADD] base_json_request: Module to allow standard JSON requests

192adb4

* Create a module that circumvents the JSON-RPC requirement for all requests with application/json

[ADD] base_web_hook: Create abstract web hooks

2839174

* Create a module to allow for the receipt of web hooks in an abstract fashion

lasley added the work in progress label Oct 10, 2017

lasley added this to the 10.0 milestone Oct 10, 2017

lasley mentioned this pull request Oct 10, 2017

[ADD] base_json_request: Module to allow standard JSON requests #3

Open

lasley force-pushed the release/10.0/base_webhook branch from 365114e to 7a6d879 Compare October 11, 2017 18:44

Add token adapter/interface mechanism

071843b

lasley force-pushed the release/10.0/base_webhook branch from 7a6d879 to 071843b Compare October 11, 2017 18:53

lasley added 3 commits October 11, 2017 12:45

Add headers to token verification

adcb447

Add inherits on adapters

c93ca2a

Usability

8fe5b08

lasley commented Oct 11, 2017

View reviewed changes

Send headers to hook receive

c2e781c

lasley force-pushed the release/10.0/base_webhook branch from 2e04110 to c2e781c Compare October 11, 2017 21:10

Views and usability

24004e3

lasley commented Oct 13, 2017

View reviewed changes

lasley added 3 commits October 14, 2017 14:19

Add full URI

87d90a3

Add auth note in receive

616ade0

Allow circumvention of automatic adapter creation on hook creation

854e366

lasley force-pushed the release/10.0/base_webhook branch from 435c307 to 854e366 Compare October 16, 2017 19:17

lasley added 2 commits October 17, 2017 12:42

Usability updates & add a request bin

9057d8f

Remove unused model and add user to request bin

162e618

lasley force-pushed the release/10.0/base_webhook branch from a9ae4a8 to b292801 Compare October 17, 2017 21:16

Add an HTTP endpoint and an always true token

e310be4

lasley force-pushed the release/10.0/base_webhook branch from b292801 to e310be4 Compare October 17, 2017 21:20

Bug fixes - it works!

8255239

lasley added 2 commits October 18, 2017 14:57

Add security and remove csrf from http route

f203779

Save request bin as raw strings

b23a071

lasley added 3 commits October 26, 2017 16:01

Add an authentication-required HTTP endpoint

3ca31ab

Oops

675e5c7

Add some sensible security

0ee415f

lasley mentioned this pull request Nov 28, 2017

Have a bot do the module version bumping OCA/maintainer-tools#314

Closed

pntabuye reviewed May 8, 2018

View reviewed changes

pedrobaeza mentioned this pull request Aug 8, 2018

[11.0][MIG] webhook OCA/server-tools#1337

Closed

mlaitinen suggested changes Aug 8, 2018

View reviewed changes

gurneyalex closed this Jul 29, 2024

Uh oh!

Conversation

lasley commented Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lasley Oct 11, 2017

Choose a reason for hiding this comment

Uh oh!

lasley commented Oct 11, 2017

Uh oh!

lasley Oct 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lasley commented Oct 17, 2017

Uh oh!

hbrunn commented Nov 28, 2017

Uh oh!

lasley commented Nov 28, 2017

Uh oh!

hbrunn commented Nov 28, 2017

Uh oh!

hbrunn commented Nov 28, 2017

Uh oh!

lasley commented Nov 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lasley commented Nov 28, 2017

Uh oh!

pntabuye left a comment

Choose a reason for hiding this comment

Uh oh!

pntabuye May 8, 2018

Choose a reason for hiding this comment

Uh oh!

mlaitinen Aug 8, 2018

Choose a reason for hiding this comment

Uh oh!

mlaitinen Aug 8, 2018

Choose a reason for hiding this comment

Uh oh!

gurneyalex commented Jul 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lasley commented Oct 10, 2017 •

edited

Loading

lasley Oct 13, 2017 •

edited

Loading

lasley commented Nov 28, 2017 •

edited

Loading