Update RegionAccessor#getMoonPhase to take in account environment attributes from world#13543
Open
Doc94 wants to merge 4 commits intoPaperMC:mainfrom
Open
Update RegionAccessor#getMoonPhase to take in account environment attributes from world#13543Doc94 wants to merge 4 commits intoPaperMC:mainfrom
Doc94 wants to merge 4 commits intoPaperMC:mainfrom
Conversation
Doc94
force-pushed
the
feature/moon-phase-update
branch
from
53e286f to
7f72d1f
Compare
Contributor
|
It might be better to wait for the upcoming environmental attribute api and just fetch the dimensional value for now like the methods around CraftWorld#isNatural (which has a todo if you want to look at it). |
Member
Author
then can move this to just deprecate the method? |
Contributor
|
Yes, just deprecate the method for now with no alternative + mention upcoming env attribute API. |
Doc94
force-pushed
the
feature/moon-phase-update
branch
from
e06a68f to
388e13c
Compare
Doc94
changed the title
Lulu13022002
changed the title
Lulu13022002
changed the title
Lulu13022002
force-pushed
the
feature/moon-phase-update
branch
from
495f5f4 to
edc03b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13542 by adding new methods for get the moon phase using the location for work with the Environment Attributes