OldEnum#valueOf check for valid NamespacedKey#13596
Open
Doc94 wants to merge 4 commits intoPaperMC:mainfrom
Open
OldEnum#valueOf check for valid NamespacedKey#13596Doc94 wants to merge 4 commits intoPaperMC:mainfrom
Doc94 wants to merge 4 commits intoPaperMC:mainfrom
Conversation
Doc94
force-pushed
the
fix/13594-OldEnum-valueOf-namespace-null
branch
from
431b0e7 to
8b54869
Compare
electronicboy
approved these changes
Feb 3, 2026
Contributor
|
Make sure to catch all the places using NamespacedKey.fromString like Art.getByName, also I think this can just fallback to the latter precondition keep in mind this try to mimic Enum#valueOf. |
Member
Author
latter precondition? |
Lulu13022002
reviewed
Feb 3, 2026
Lulu13022002
force-pushed
the
fix/13594-OldEnum-valueOf-namespace-null
branch
from
201c383 to
36108a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix #13594 where the OldEnum#valueOf (its a reference i know its not like that) can take invalid name like "@" and throw a NPE in the Registry class because the NamespaceKey generated before is null for the invalid characters, the change its just check the NamespaceKey and throw an issue, the only exception its the Sound where another check is made later then just avoid check Registry if the key was invalid