Block Capturing System

[Owen1212055]

Fundamental rewrite of how blocks are captured for block place event. Prioritizes vanilla behavior.

Tested Fixes:

• Placing book in Lectern fires block place event #9759
• Bonemealing dripleaf causes broken state
• Log stripping is mistakenly considered as a place action #12256
• Inventory desync & block update happening when canceling lily pad in BlockPlaceEvent #9504
• Datapack that uses setblock command unable to place one high versions of two high plants in paper and spigot #11728
• Observers detect saplings advancing their growth stage once and then they stop #6458 (better fix)
• Block entities not being correct in tree placement (better fix)
• Tripwire Hook duplication bug not working on 1.21.4 PaperMC #12114
• End portal placement being considered in BlockPlaceEvent
• Infinite Hanging Roots Duplication via Hoe Right-Click on Rooted Dirt + BlockPlaceEvent Cancellation #13536 (no longer fired)

#13586 (working towards)
any block modification in item interaction counting as block place event
fixes edge cases required by random block types
fixes edge cases with physics being fired on structure placement despite being canceled

big todos:

• Dispenser related stuff
• Bone meal related stuff, we need to pass more context in order to get the tree event properly working
• Treetype field removal from saplingblock

[papermc-pr-publishing]

Last updated for: f46fbbe20b4344b534458ba4b1fb14836d424a90.

Download the Paperclip jar for this pull request: paper-13608.zip

Maven Publication

The artifacts published by this PR:

• 📦 io.papermc.paper:dev-bundle:1.21.11-R0.1-SNAPSHOT
• 📦 io.papermc.paper:paper-api:1.21.11-R0.1-SNAPSHOT

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven("https://maven-prs.papermc.io/Paper/pr13608") {
        name = "Maven for PR #13608" // https://github.com/PaperMC/Paper/pull/13608
        mavenContent {
            includeModule("io.papermc.paper", "dev-bundle")
            includeModule("io.papermc.paper", "paper-api")
        }
    }
}

[Toffikk]

Paper/paper-server/patches/features/0032-Block-Capture-System.patch

Lines 2138 to 2139 in f4074a0

	- if (!(randomSource.nextFloat() >= this.probability)) {
	+ if (!(randomSource.nextFloat() >= 1)) {

why was this change made?

[Owen1212055]

@Toffikk It was a temporary change for testing beehive behavior. 😄