Open up factor support in nafill #7539
Open
+43
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7539 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 87 87
Lines 16733 16739 +6
=======================================
+ Hits 16561 16567 +6
Misses 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit bc87775 Download link for the artifact containing the test results: ↓ atime-results.zip
|
MichaelChirico
force-pushed
the
nafill-factor
branch
from
fd689ba to
c8693ef
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ben-schwen
reviewed
Dec 28, 2025
| if (!isNull(ATTRIB(VECTOR_ELT(x, i)))) | ||
| copyMostAttrib(VECTOR_ELT(x, i), VECTOR_ELT(ans, i)); | ||
| SEXP xi = VECTOR_ELT(x, i); | ||
| if (!isNull(ATTRIB(xi))) { |
Member
There was a problem hiding this comment.
Suggested change
| if (!isNull(ATTRIB(xi))) { | |
| if (ANY_ATTRIB(ATTRIB(xi))) { |
probably should go after #7487 for the backport of R < 4.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another easy win for #3992.
The only difficulty is ensuring that if
fillis set to something outsidelevels(x), the output is a well-formed factor.coerceAs()already has some logic to that effect, we've just got to take care & actually use it.