Open
Conversation
Contributor
dengliming
commented
Apr 17, 2021
- Use DataType.valueOf instead of DataType.getDataTypefromString
- Fix model test in windows
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 87.62% 87.73% +0.10%
==========================================
Files 12 12
Lines 598 587 -11
Branches 83 78 -5
==========================================
- Hits 524 515 -9
+ Misses 34 33 -1
+ Partials 40 39 -1
Continue to review full report at Codecov.
|
DvirDukhan
previously approved these changes
Apr 18, 2021
|
hi @dengliming |
Contributor
Author
|
@DvirDukhan yes. but I think these are low priority issues. We can ignore it for now. |
Contributor
|
@gkorland Did you notice that thoretically it's a breaking change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.