CU-868f7n1u3 Fixing bugs and removing dropper for package.

[ucswift]

Summary by CodeRabbit

• New Features

  • None

• Chores

  • Streamlined JavaScript assets by removing an unused third‑party library from the internal bundle to reduce load overhead. No functional changes expected.

• Style

  • Minor formatting cleanup in analytics code with no impact on behavior.

[coderabbitai]

Walkthrough

Dropzone JS is commented out from the internal JavaScript bundle configuration in Startup.cs. A minor formatting tweak is made to the Countly user_details payload in resgrid.common.analytics.js. No functional logic or public API changes are introduced.

Changes

Cohort / File(s)	Summary
Asset bundling configuration Web/Resgrid.Web/Startup.cs	Commented out lib/deltablot/dropzone/dist/dropzone.js from WebOptimizer JS bundle; retained js/site.min.js. No other bundle changes.
Analytics formatting Web/Resgrid.Web/wwwroot/js/app/common/analytics/resgrid.common.analytics.js	Adjusted brace/line formatting in Countly user_details payload within register; no logic or data changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• CU-868f7n1u3 Adding in Countly for analytics. PW validation fix. #244 — Also modifies Web/Resgrid.Web/Startup.cs for Dropzone inclusion and touches analytics; likely conflicting or sequential changes around asset bundling and Countly/Aptabase integration.

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title partially matches the changeset: it refers to removing a package which aligns with the Dropzone removal from the WebOptimizer bundles and mentions bug fixes which broadly covers the minor analytics formatting change; however the phrase "removing dropper" appears to be a typo (should likely be "Dropzone") and "Fixing bugs" is overly generic and does not clearly describe the primary change.

Poem

In bundles I hop, a tidy prune,
Dropzone naps, not loading soon.
Analytics lines realign with grace,
Braces spaced in their proper place.
With whiskers twitch and tidy cheer,
This rabbit keeps the codepath clear. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[request-info]

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Web/Resgrid.Web/Startup.cs (1)

360-369: Orphaned Dropzone CSS: remove to avoid dead bytes.

dropzone.css is still bundled while the JS is gone. If Dropzone is fully retired, drop the CSS too.

-					"lib/deltablot/dropzone/dist/dropzone.css", "css/style.css");
+					"css/style.css");

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0d01c0 and c40f6dd.

📒 Files selected for processing (2)

• Web/Resgrid.Web/Startup.cs (1 hunks)
• Web/Resgrid.Web/wwwroot/js/app/common/analytics/resgrid.common.analytics.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.cs

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.cs: Prefer functional patterns and immutable data where appropriate in C#
Use modern C# features appropriately
Use meaningful, descriptive names for types, methods, and parameters; avoid unclear abbreviations
Separate state from behavior (e.g., use records for state and place operations in separate static classes)
Prefer pure methods over methods with side effects
Use extension methods appropriately for domain-specific operations
Design for testability; avoid hidden dependencies inside methods and prefer explicit, pure functions
Minimize constructor injection; keep the number of injected dependencies small
Prefer composition with interfaces to extend behavior

Files:

• Web/Resgrid.Web/Startup.cs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: build
• GitHub Check: Analyze (csharp)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (csharp)

🔇 Additional comments (2)

Web/Resgrid.Web/Startup.cs (1)

381-383: ```shell
#!/bin/bash
set -euo pipefail

echo "PWD: $(pwd)"
echo "--- ls -la (repo root) ---"
ls -la || true

echo "--- rg version ---"
rg --version || true

echo "--- Count files ---"
find . -type f | wc -l || true

echo "--- List some files (top levels) ---"
find . -maxdepth 3 -type f | sed -n '1,200p' || true

echo "--- Search for Dropzone JS API usages (ignore .gitignore disabled) ---"
rg -nP -S -uu -C2 '\bDropzone\b|new\s+Dropzone(|Dropzone.autoDiscover|Dropzone.options' || true

echo "--- Search for markup/CSS usages (case-insensitive) ---"
rg -nP -S -uu -C2 '\bdropzone\b' --ignore-case || true

echo "--- Search for asset references ---"
rg -nP -S -uu -C2 'dropzone.js|dropzone.css' || true

echo "--- Locate Startup.cs and print lines ~360-390 ---"
file=$(rg --files -uu | grep -i 'Startup.cs' | head -n1 || true)
if [ -n "$file" ]; then
echo "Found Startup.cs: $file"
sed -n '360,390p' "$file" || true
else
echo "Startup.cs not found"
fi

</blockquote></details>
<details>
<summary>Web/Resgrid.Web/wwwroot/js/app/common/analytics/resgrid.common.analytics.js (1)</summary><blockquote>

`25-26`: **LGTM on formatting tweak.**

No behavior change; payload remains identical.

</blockquote></details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

[ucswift]

Approve

[github-actions]

This PR is approved.