Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 16, 2026

Closes ROO-542.

Summary

  • Warn when enabled MCP tools exceed MAX_MCP_TOOLS_THRESHOLD to reduce model confusion; export the threshold via shared types and CLI constants for reuse.
  • Emit too_many_tools_warning chat rows from task flow and render a new warning UI using the reusable WarningRow component plus translated copy for tool/server counts.
  • Add tests covering MCP tool counting rules, warning rendering, docs link behavior, and updated locales.
Screenshot 2026-01-16 at 10 23 26

Important

Introduces a warning system for excessive MCP tools to prevent model confusion, with UI updates and tests.

  • Behavior:
    • Warns when enabled MCP tools exceed MAX_MCP_TOOLS_THRESHOLD to prevent model confusion.
    • Emits too_many_tools_warning chat rows in Task.ts and renders warning UI using WarningRow.
  • Constants:
    • Exports MAX_MCP_TOOLS_THRESHOLD in constants.ts and mcp.ts.
  • UI Components:
    • Adds TooManyToolsWarning and WarningRow components in ChatRow.tsx.
  • Tests:
    • Adds tests for tool counting, warning rendering, and locale updates in TooManyToolsWarning.spec.tsx and WarningRow.spec.tsx.
  • Locales:
    • Updates translations for warning messages in multiple locale files.

This description was created by Ellipsis for 18bcd22. You can customize this summary. It will automatically update as commits are pushed.

- Add WarningRow component for displaying generic warnings with icon, title, message, and optional docs link
- Add TooManyToolsWarning component that shows when users have more than 40 MCP tools enabled
- Add MAX_MCP_TOOLS_THRESHOLD constant (40)
- Add i18n translations for the warning message
- Integrate warning into ChatView to display after task header
- Add comprehensive tests for both components

Closes ROO-542
@roomote
Copy link
Contributor Author

roomote bot commented Jan 16, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The new commits successfully move the tool counting logic from frontend to backend, add the warning as a ClineSay message type that persists in task history, and improve i18n with proper pluralization support for all 18 locales.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@brunobergher brunobergher marked this pull request as ready for review January 16, 2026 10:34
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Jan 16, 2026
@roomote
Copy link
Contributor Author

roomote bot commented Jan 16, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The implementation correctly warns users when too many MCP tools are enabled (>40). Backend tool counting logic properly filters disabled/disconnected servers and disabled tools, emits a persistent warning message in task history, and the frontend renders it with proper i18n pluralization support.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

4 participants