-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(roo): update default model to anthropic/claude-sonnet-4.5 #11145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
roomote
wants to merge
1
commit into
main
Choose a base branch
from
feature/EXT-717-update-roo-default-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,14 +93,14 @@ vitest.mock("../../providers/fetchers/modelCache", () => ({ | |
| getModelsFromCache: vitest.fn((provider: string) => { | ||
| if (provider === "roo") { | ||
| return { | ||
| "xai/grok-code-fast-1": { | ||
| maxTokens: 16_384, | ||
| contextWindow: 262_144, | ||
| supportsImages: false, | ||
| supportsReasoningEffort: true, // Enable reasoning for tests | ||
| "anthropic/claude-sonnet-4.5": { | ||
| maxTokens: 8_192, | ||
| contextWindow: 200_000, | ||
| supportsImages: true, | ||
| supportsReasoningEffort: true, | ||
| supportsPromptCache: true, | ||
| inputPrice: 0, | ||
| outputPrice: 0, | ||
| inputPrice: 3, | ||
| outputPrice: 15, | ||
| }, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we want to add the cache price too |
||
| "minimax/minimax-m2:free": { | ||
| maxTokens: 32_768, | ||
|
|
@@ -141,7 +141,7 @@ describe("RooHandler", () => { | |
|
|
||
| beforeEach(() => { | ||
| mockOptions = { | ||
| apiModelId: "xai/grok-code-fast-1", | ||
| apiModelId: "anthropic/claude-sonnet-4.5", | ||
| } | ||
| // Set up CloudService mocks for successful authentication | ||
| mockHasInstanceFn.mockReturnValue(true) | ||
|
|
@@ -410,7 +410,7 @@ describe("RooHandler", () => { | |
|
|
||
| it("should handle any model ID since models are loaded dynamically", () => { | ||
| // Test with various model IDs - they should all work since models are loaded dynamically | ||
| const testModelIds = ["xai/grok-code-fast-1", "roo/sonic", "deepseek/deepseek-chat-v3.1"] | ||
| const testModelIds = ["anthropic/claude-sonnet-4.5", "roo/sonic", "deepseek/deepseek-chat-v3.1"] | ||
|
|
||
| for (const modelId of testModelIds) { | ||
| const handlerWithModel = new RooHandler({ apiModelId: modelId }) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,11 +24,11 @@ describe("getRooModels", () => { | |
| object: "list", | ||
| data: [ | ||
| { | ||
| id: "xai/grok-code-fast-1", | ||
| id: "anthropic/claude-sonnet-4.5", | ||
| object: "model", | ||
| created: 1234567890, | ||
| owned_by: "xai", | ||
| name: "Grok Code Fast 1", | ||
| owned_by: "anthropic", | ||
| name: "Claude Sonnet 4.5", | ||
| description: "Fast coding model", | ||
| context_window: 262144, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess doesn't matter for a test, but these stats don't match |
||
| max_tokens: 16384, | ||
|
|
@@ -63,7 +63,7 @@ describe("getRooModels", () => { | |
| ) | ||
|
|
||
| expect(models).toEqual({ | ||
| "xai/grok-code-fast-1": { | ||
| "anthropic/claude-sonnet-4.5": { | ||
| maxTokens: 16384, | ||
| contextWindow: 262144, | ||
| supportsImages: true, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think opus might be a better choice? Could end up being cheaper than sonnet if you use the full 1M token context window that we normally provide in the Roo Code Router.