Skip to content

Implement goto definition for send and public send #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafaelfranca merged 3 commits into from
Jan 19, 2026
Merged

Implement goto definition for send and public send #3882

rafaelfranca merged 3 commits into from
Jan 19, 2026

Conversation

@sucicfilip
Copy link
Contributor

@sucicfilip sucicfilip commented Jan 2, 2026 •
edited
Loading

Motivation

Closes #3848

Implementation

I used vinistock's comment as a guide while implementing this feature.

Manual Tests

See the issue, I believe it is pretty self-explanatory.

@sucicfilip sucicfilip marked this pull request as ready for review January 2, 2026 19:48
@sucicfilip sucicfilip requested a review from a team as a code owner January 2, 2026 19:48
@sucicfilip sucicfilip force-pushed the feature/goto-definition-for-send-and-public-send branch 4 times, most recently from bbe7546 to b80473a Compare January 2, 2026 22:13
@rafaelfranca rafaelfranca added enhancement New feature or request server This pull request should be included in the server gem's release notes labels Jan 19, 2026
vinistock
vinistock approved these changes Jan 19, 2026
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This looks good, we just need to fix the type checking errors since arguments is a nilable node. You'll also need a rebase to get CI to run against 4.0.

@rafaelfranca
Copy link
Member

rafaelfranca commented Jan 19, 2026

I already fixed those problems @vinistock

@rafaelfranca rafaelfranca force-pushed the feature/goto-definition-for-send-and-public-send branch from 28ef606 to ec9c083 Compare January 19, 2026 21:58
@vinistock
Copy link
Member

vinistock commented Jan 19, 2026

I already fixed those problems @vinistock

Thank you! Unfortunately, there's a styling issue now 😬

@rafaelfranca rafaelfranca force-pushed the feature/goto-definition-for-send-and-public-send branch from ec9c083 to 25bab9d Compare January 19, 2026 22:00
@rafaelfranca
Copy link
Member

rafaelfranca commented Jan 19, 2026

Fixed as well

@rafaelfranca rafaelfranca merged commit f397736 into Shopify:main Jan 19, 2026
20 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinistock vinistock vinistock approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request server This pull request should be included in the server gem's release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Go-to-Definition work for object.send(:method_name)

3 participants

@sucicfilip @rafaelfranca @vinistock