Option to turn on parallel computation for CCG in numba #4305
+59
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…e into parallel_correlograms
for more information, see https://pre-commit.ci
…e into parallel_correlograms
This was referenced Jan 8, 2026
alejoe91
reviewed
Feb 5, 2026
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
Collaborator
Author
|
I've made fast_mode "auto" by default, (can also be "never" or "always"). "auto" means that if there are more than 300 neurons and "numba", it is activated |
for more information, see https://pre-commit.ci
Member
Maybe "off"/"on" instead of never/always? :) |
Collaborator
Author
|
done, let's go for on/off |
alejoe91
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to activate a fast_mode for the numba implementation. The mode will parallelize use prange(), but at the cost of some (rare) racing conditions that might possibily bring some numerical instabilities. Tested on 1000 units firing at few herz for 1000s, the error is less than one spike out of a million compared to the normal one