-
Notifications
You must be signed in to change notification settings - Fork 50
Add browser data cleanup flow for CLI account deletion #1423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: tyler-dane <[email protected]>
Co-authored-by: tyler-dane <[email protected]>
…improve error messages Co-authored-by: tyler-dane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot remove emojis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Removed emojis and replaced with plain text in commit 8569d07.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use tailwind, not styled-components @copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Removed styled-components file and replaced with Tailwind CSS classes in commit 8569d07.
…gly-type env Co-authored-by: tyler-dane <[email protected]>
Co-authored-by: tyler-dane <[email protected]>
tyler-dane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove index file and just use the original component like the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Removed index.ts and updated router to import directly from Cleanup.tsx component file in commit 7457970.
Co-authored-by: tyler-dane <[email protected]>
Done. All emojis have been removed from cleanup-related code. Tests are already included and passing (9 unit tests covering the cleanup utility). Changes in commit 7457970. |
Implementation Complete ✅
This PR implements a privacy-focused browser data cleanup feature for CLI account deletion.
All PR Feedback Addressed
File Naming ✅
browserCleanup.util.ts→browser.cleanup.util.tsbrowserCleanup.util.test.ts→browser.cleanup.util.test.tsUI Updates ✅
styled.tsand replaced styled-components with Tailwind CSS classesCleanup.tsxto use inline Tailwind classesComponent Import Pattern ✅
index.tsfile from Cleanup viewCleanup.tsxcomponent fileCLI Environment Handling ✅
getCleanupUrl()CLI_ENVandENVIRONMENTconstantsEnvironment_ClitypeKey Features
Testing & Quality Assurance
What Gets Cleaned Up
session.signOut())compass.orcompass.today.tasks.*compass-localdatabaseReady for review and merge.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.