Quest gossip added for 10722, also mob abilities#44
Open
Leadballoon2000 wants to merge 1 commit intoTBC-DB:masterfrom
Open
Quest gossip added for 10722, also mob abilities#44Leadballoon2000 wants to merge 1 commit intoTBC-DB:masterfrom
Leadballoon2000 wants to merge 1 commit intoTBC-DB:masterfrom
Conversation
Author
|
Dude, rename the commit, put that into commit message :D |
Leadballoon2000
changed the title
|
|
Gossip Id's - are coming from sniff... and always must be the same (no diff if its UDB , TBC-DB, trinity etc...) we cannot change them |
|
I have a rule atm that we try to use UDB condition ids whenever possible when backporting, to mitigate the mess among versions. :P (for new ones, i use the rule you mentioned) |
Ported from TrinityCore 'Thanks to nelegalno and gecko32'
Author
|
OK, I've reconciled the condition IDs with UDB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.