-
Notifications
You must be signed in to change notification settings - Fork 53
Migrate to ESLint 9 with flat config #5690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Co-authored-by: jmfrancois <19857479+jmfrancois@users.noreply.github.com>
Co-authored-by: jmfrancois <19857479+jmfrancois@users.noreply.github.com>
Co-authored-by: jmfrancois <19857479+jmfrancois@users.noreply.github.com>
Co-authored-by: jmfrancois <19857479+jmfrancois@users.noreply.github.com>
… and JSON syntax Co-authored-by: jmfrancois <19857479+jmfrancois@users.noreply.github.com>
|
Storybook for this PR deployed on this github page |
| "test:watch": "cross-env TZ=UTC talend-scripts test --watch", | ||
| "test:cov": "cross-env TZ=UTC talend-scripts test --coverage", | ||
| "lint": "talend-scripts lint ./src/**/*.js ./stories/**/*.js ./.storybook/**/*.js", | ||
| "lint": "eslint .", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot can you lint only the same files as before please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Restored the original file patterns for packages that had specific paths:
faceted-search-query-client:eslint ./src/**/*.js ./stories/**/*.js ./.storybook/**/*.jsfaceted-search:eslint ./src/**/*.js ./stories/**/*.js ./.storybook/**/*.jslocal-libs-webpack-plugin:eslint lib/**/*.js
These now lint only the same files as before. (commit 32445e7)
…om paths Co-authored-by: jmfrancois <19857479+jmfrancois@users.noreply.github.com>
ESLint 8 to ESLint 9 Migration - Complete ✅
This PR successfully migrates the repository from ESLint 8 to ESLint 9 with flat config format.
Summary of Changes
Updated @talend/eslint-config package to support ESLint 9
eslint.config.jsusing flat config format.eslintrc.jsonto flat configindex.jsas main entry point for compatibilityRemoved lint command from @talend/scripts-core
exit(1)Updated all package lint scripts (36 packages)
"talend-scripts lint"with"eslint .""eslint ."Added ESLint 9 configs to all packages
eslint.config.jsin 51 packages@talend/eslint-configeslint.config.jsUpdated documentation
Code review and security
Breaking Changes
.eslintrcformattalend-scripts lintcommand removed - useeslint .directlyTesting Notes
.eslintrc.jsonfiles during transitionyarn lintOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.