Skip to content

Conversation

@siwelwerd
Copy link
Contributor

@siwelwerd siwelwerd commented Jan 15, 2026

Addresses #898 . This converts the appendix that is the library of graphs into all Prefigure. This should give templates for converting all of the other graphs in both Precalculus and Calculus.

@github-actions
Copy link

@siwelwerd
Copy link
Contributor Author

Hmmm, there is some weirdness in the size of the images that I wasn't seeing when I built it. I don't see anything in the code that would make them different sizes.

Also we get the keyboard instructions repeatedly. I wonder if there is some publisher option to hide those.

@siwelwerd
Copy link
Contributor Author

I think I was using an updated PreTeXt to build because of #909, I wonder if that is the cause of the difference... maybe we can merge that in and see if that changes the preview.

@siwelwerd
Copy link
Contributor Author

Ah okay, I think we get the keyboard controls whenever we use <annotation>s. Which should probably be always. But in the <sidebyside> it seems to only put them once at the bottom.

@github-actions
Copy link

@siwelwerd
Copy link
Contributor Author

Hmmm, now it is complaining about ln (but succeeding?)

error: Unknown function in evaluation: ln
error: Unsafe function definition: ln(x)/ln(2)
error: Error in definition: Unsafe function definition: ln(x)/ln(2)
error: Error retrieving function in graph: Unrecognized name: f

PreFigure documentation
say ln is okay

@github-actions
Copy link

@github-actions
Copy link

@siwelwerd
Copy link
Contributor Author

It's no longer complaining but the newer version of PreTeXt doesn't seem to want to show them at all 🤷🏼‍♂️

@siwelwerd
Copy link
Contributor Author

So, when I run pretext build -g precalculus-preview I believe it is only producing output/precalculus-preview/generated/prefigure/prefigure-graph-x.svg. However, the HTML is looking for output/precalculus-preview/generated/prefigure/prefigure-graph-x-diagcess.svg .

I wonder if this is related to PreTeXtBook/pretext#2758

@github-actions
Copy link

@siwelwerd
Copy link
Contributor Author

It was indeed related. We were defaulting to an older version of PreFigure, but with the newer PreTeXt that was assuming a newer version of PreFigure.

I feel like the pretext CLI dependency should be telling us what version of prefig to run instead of specifying it manually though (as I did in the last commit to make it work).

@github-actions
Copy link

@github-actions
Copy link

@siwelwerd
Copy link
Contributor Author

Okay @StevenClontz , now it's working. Take a look (and play with navigating through the annotations if you can).

Since we need to bump the pretext version, should we also grab a newer image from Dockerhub? Looks like 1.7 was pushed this week, we have 1.2 listed in the devcontainer right now (which is where we were getting the older prefigure installed by default causing the incompatibility with the newer pretext).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants