-
Notifications
You must be signed in to change notification settings - Fork 28
Convert Precalculus images to Prefigure #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚀 Preview available 🚀https://30222589.tbil.pages.dev
|
|
Hmmm, there is some weirdness in the size of the images that I wasn't seeing when I built it. I don't see anything in the code that would make them different sizes. Also we get the keyboard instructions repeatedly. I wonder if there is some publisher option to hide those. |
|
I think I was using an updated PreTeXt to build because of #909, I wonder if that is the cause of the difference... maybe we can merge that in and see if that changes the preview. |
|
Ah okay, I think we get the keyboard controls whenever we use |
🚀 Preview available 🚀https://6f1bb3e1.tbil.pages.dev
|
|
Hmmm, now it is complaining about PreFigure documentation |
🚀 Preview available 🚀https://b531b64a.tbil.pages.dev
|
source/precalculus/source/meta/prefigure/graph-logarithm-natural.xml
Outdated
Show resolved
Hide resolved
🚀 Preview available 🚀https://42ef166c.tbil.pages.dev
|
|
It's no longer complaining but the newer version of PreTeXt doesn't seem to want to show them at all 🤷🏼♂️ |
|
So, when I run I wonder if this is related to PreTeXtBook/pretext#2758 |
🚀 Preview available 🚀https://b110ea1c.tbil.pages.dev
|
|
It was indeed related. We were defaulting to an older version of PreFigure, but with the newer PreTeXt that was assuming a newer version of PreFigure. I feel like the pretext CLI dependency should be telling us what version of prefig to run instead of specifying it manually though (as I did in the last commit to make it work). |
🚀 Preview available 🚀https://a150289b.tbil.pages.dev
|
🚀 Preview available 🚀https://1e7e901b.tbil.pages.dev
|
|
Okay @StevenClontz , now it's working. Take a look (and play with navigating through the annotations if you can). Since we need to bump the pretext version, should we also grab a newer image from Dockerhub? Looks like 1.7 was pushed this week, we have 1.2 listed in the devcontainer right now (which is where we were getting the older prefigure installed by default causing the incompatibility with the newer pretext). |
Addresses #898 . This converts the appendix that is the library of graphs into all Prefigure. This should give templates for converting all of the other graphs in both Precalculus and Calculus.