Fix the year and add a schedule to run the tests on Jan 2nd each year. #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
So we at least notice the fail.
samcunliffe
changed the title
matt-graham
approved these changes
Jan 16, 2026
Collaborator
matt-graham
left a comment
matt-graham
left a comment
There was a problem hiding this comment.
Agreed that coming up with a better long term solution would be good but also that at least having a noisy warning to remind us is an improvement over the current situation. Have suggested possibly making comment explaining why we have added this schedule line a bit more explicit to not confuse future us, but ambivalent as to whether this is needed to approving now. Thanks for fixing @samcunliffe!
Co-authored-by: Matt Graham <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression tests are dumb. And years change.
I'd love it if we could find a way not to have the full-output regression test.
Failing that, I'm proposing a
cronso that we at least get an email on the 2nd January, which reminds us to fix the year. I acknowledge that it's a dumb solution, but it's a dumb problem: so fairs fair.