[JS API] Expose BinaryenStringConst #8160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

rayan-mazouz wants to merge 1 commit into WebAssembly:main from rayan-mazouz:main

+5 −0

rayan-mazouz commented Dec 25, 2025

No description provided.


          [JS API] Expose BinaryenStringConst

1f2038a

spotandjake reviewed

View reviewed changes

Contributor

spotandjake left a comment

The binding looks good to me; it probably makes sense to add a test, though.

I think the place for this test would be here https://github.com/WebAssembly/binaryen/blob/c2e47d3bffdb66e237525da24d8c28f4b5402f20/test/binaryen.js/gc.js in the valueList, though I could be wrong.

(Just a random reviewer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet