challeng7 in python

[py2k5]

No description provided.

[shaowenliu]

'num + 1 not in numbers is O(n), and you put it in the for loop, together it's O(n square) complexity?

[ManuelMeraz]

@py2k5

• Code Correctness
  Your challenge 7 solution needs to be worked on. I think it's just a misunderstanding of how the statement if i in list works. To confirm whether something is in a list this statement will iterate through your list until it finds the number, then check the next number and iterate through the list again, until the first for loop finishes. In a sense you have 2 nested for loops each dependent on the length of the input to find the missing number making this O(N^2). See if you can improve on this algorithm.
• Code Style
• Code Documentation
• Path Structure
• Merge Pull Request

[py2k5]

I am still learning python. :)

…

On Fri, Jan 13, 2017 at 12:09 PM, Manuel Meraz ***@***.***> wrote: @slansford <https://github.com/slansford> - *Code Correctness* Your challenge 7 solution needs to be worked on. I think it's just a misunderstanding of how the statement if i in list works. To confirm whether something is in a list this statement will iterate through your list until it finds the number, then check the next number and iterate through the list again, until the first for loop finishes. In a sense you have 2 nested for loops each dependent on the length of the input to find the missing number making this O(N^2). See if you can improve on this algorithm. - *Code Style* - *Code Documentation* - *Path Structure* - *Merge Pull Request* — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#386 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXw4VCsXbk-NREaqykuNytk6eaZ6FZZxks5rRxwtgaJpZM4LhuB6> .

[ManuelMeraz]

@py2k5 We can help you in the slack chat if you'd like or I can give you some hints here as well on how to improve. I'd also recommend looking at some of the other python solutions for this challenge.

[py2k5]

sure in fact I wll be glad. let me know when we can get into a call.

…

On Jan 13, 2017 8:06 PM, "Manuel Meraz" ***@***.***> wrote: @py2k5 <https://github.com/py2k5> We can help you in the slack chat if you'd like or I can give you some hints here as well on how to improve. I'd also recommend looking at some of the other python solutions for this challenge. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#386 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXw4VAh06fCu5Wjik5hsxXx3a8mtgMhAks5rR4wFgaJpZM4LhuB6> .