Add handle_exception method to log errors during GenerationJob execution #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
handle_exceptionclass method to Rescue concernFixes #306
Summary
handle_exceptionclass method toActiveAgent::Concerns::Rescueso thatGenerationJob#handle_exception_with_agent_classhas something to callRoot cause
GenerationJob#handle_exception_with_agent_classcallsklass.handle_exception(exception)(a class method), but theRescueconcern only defines instance methods. This causes aNoMethodErrorwhen a job-level exception is raised duringgenerate_later.Fix
Add a
handle_exceptionclass method to theRescueconcern'sclass_methodsblock. It logs the exception class, message, and first 10 lines of the backtrace viaRails.logger.error.Test plan
generate_laterand confirm it is logged rather than raisingNoMethodErrorrescue_frominstance-level handlers still work as expected