Open
Conversation
remplaced | with || in bolean logic, avoiding compiler warnings and possible bug.
Confirm that CLA was submitted March 26th 2025 |
|
@kwblackstone Hi can you help take a look? Thank you! |
jakes-adobe
approved these changes
May 14, 2025
Contributor
jakes-adobe
left a comment
jakes-adobe
left a comment
There was a problem hiding this comment.
This looks great, @metaremi, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
replaced | with || in boolean logic, avoiding compiler warnings and possible bug.
Related Issue
Motivation and Context
fixes compilation warning reported with -Wbitwise-instead-of-logical
How Has This Been Tested?
no change in behavior
Screenshots (if appropriate):
Types of changes
Checklist: