chore: use typeof globalThis to reference global object
#9402
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think |
Contributor
Author
The GH issue describes it as a built-in for TypeScript. Is it possible for the CI check to run to validate this via |
Contributor
Author
Thanks, I've added it to ESLint's globals for TypeScript exclusively, and it appears to be passing the |
snowystinger
approved these changes
Jan 5, 2026
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Thanks, maybe we can eventually update our ecmaVersion to support this without the need for the explicit global
yihuiliao
changed the title
typeof globalThistypeof globalThis to reference global object
yihuiliao
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9250