fix: prevent undefined values in TextNodeRenderable components #7335
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Line 1817: Remove optional chaining on props.output since Match guard already ensures it's defined, use non-null assertion instead - Line 1232: Add nullish coalescing for error.data.message to provide empty string fallback Fixes crash: 'TextNodeRenderable only accepts strings, TextNodeRenderable instances, or StyledText instances'
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TextNodeRenderable only accepts strings, TextNodeRenderable instances, or StyledText instancesChanges
Patchcomponent): Remove optional chaining?.onprops.outputsince the<Match when={props.output !== undefined}>guard already ensures it's defined. Use non-null assertion!instead.?? ""forerror.data?.messageto provide empty string fallback whendatais undefined.Root Cause
The
<text>component from@opentui/coreonly accepts strings, TextNodeRenderable instances, or StyledText instances. Optional chaining (?.) can returnundefinedeven inside guarded blocks, causing the runtime error.Testing
The fix ensures all
<text>children are guaranteed to be strings:props.output!.trim()- Safe because Match guard checksprops.output !== undefinedprops.message.error?.data?.message ?? ""- Falls back to empty string