Draft
Conversation
Separated out functionality in the manager Splitter class that was only used by the fate split operation. This avoids having to expose code used by TGW to Fate making it easier to execute fate operation outside the manager.
Contributor
Author
|
Merged #6115 into this to gets splits working in distributed fate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has a lot of rough edges, but this branch has a working distributed Fate where multiple processes can run fate operations. The following are the highlights.
The foundation here is fairly solid so far. The TODOs are
Need to determine how this will work out. Seems like could do one of the following.
I am leaning towards
#1because it seems like a simpler user experience. Also it handles starting a single manager process better. It also avoid a secondary manager process that is doing nothing. Although if pursuing#1would like to keep the code clean w/ strong encapsulation between functional pieces.