Skip to content

fix: resolve property name conflicts in StructRow.toJSON()[#95] #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Divyanshu-s13 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: resolve property name conflicts in StructRow.toJSON()[#95] #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02d0421
fix: resolve property name conflicts in StructRow.toJSON()
Nov 26, 2025
e83e28d
fix: resolve TS2352 type error in MapBuilder for TypeScript 5.6+
Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/builder/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ export class MapBuilder<K extends DataType = any, V extends DataType = any, TNul
}

public setValue(index: number, value: MapValueExt<K, V>) {
const row = (value instanceof Map ? value : new Map(Object.entries(value))) as MapValue<K, V>;
const row = (value instanceof Map ? value : new Map(Object.entries(value))) as unknown as MapValue<K, V>;
const pending = this._pending || (this._pending = new Map() as MapValues<K, V>);
const current = pending.get(index) as Map<K, V> | undefined;
const current = pending.get(index);
current && (this._pendingLength -= current.size);
this._pendingLength += row.size;
pending.set(index, row);
Expand Down
3 changes: 2 additions & 1 deletion src/row/struct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ export class StructRow<T extends TypeMap = any> {
const keys = parent.type.children;
const json = {} as { [P in string & keyof T]: T[P]['TValue'] };
for (let j = -1, n = keys.length; ++j < n;) {
json[keys[j].name as string & keyof T] = getVisitor.visit(parent.children[j], i);
const fieldName = keys[j].name as string & keyof T;
json[fieldName] = getVisitor.visit(parent.children[j], i);
}
return json;
}
Expand Down