fix: resolve property name conflicts in StructRow.toJSON()[#95]#344
Open
Divyanshu-s13 wants to merge 2 commits intoapache:mainfrom
Open
fix: resolve property name conflicts in StructRow.toJSON()[#95]#344Divyanshu-s13 wants to merge 2 commits intoapache:mainfrom
Divyanshu-s13 wants to merge 2 commits intoapache:mainfrom
Conversation
Member
|
Could you add a test for this? |
Contributor
Author
|
@kou I fixed this issue. Could you please merge it? |
Contributor
Author
|
@kou By the way, I’m planning to apply for GSoC this year and really enjoying contributing here. |
Member
|
Could you add a test for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Fixed a bug in
StructRow.toJSON()where field names that match built-in JavaScript object properties (likesize,length,toString, etc.) would incorrectly return the built-in property value instead of the actual column data.The Problem
When a struct had a column named
sizeand you calledrow.toJSON(), it would return the built-insizeproperty of the object instead of the value from thesizecolumn.The Solution
Modified the
toJSON()method insrc/row/struct.tsto store the field name in a local variable before using it to access the JSON object. This prevents property name conflicts with built-in object properties.Closes #95