ATLAS-5217: updated atlas-testtools dependency scope to test#522
Merged
mneethiraj merged 1 commit intoapache:masterfrom Feb 13, 2026
Merged
ATLAS-5217: updated atlas-testtools dependency scope to test#522mneethiraj merged 1 commit intoapache:masterfrom
mneethiraj merged 1 commit intoapache:masterfrom
Conversation
mneethiraj
requested review from
chaitalicod,
Copilot,
mandarambawane,
pinal-shah and
rkundam
There was a problem hiding this comment.
Pull request overview
This PR updates the dependency management for atlas-testtools and removes the unused log4j-over-slf4j dependency across multiple modules. The changes ensure test utilities are properly scoped and remove unnecessary logging dependencies.
Changes:
- Moved atlas-testtools dependency to test scope in webapp and repository modules
- Removed log4j-over-slf4j dependency from parent POM, webapp, and test-tools modules
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webapp/pom.xml | Relocated atlas-testtools from compile to test scope section; removed log4j-over-slf4j dependency |
| test-tools/pom.xml | Removed log4j-over-slf4j test dependency (unnecessary with logback) |
| repository/pom.xml | Added test scope to atlas-testtools in graph-provider-janus profile for consistency |
| pom.xml | Removed log4j-over-slf4j from parent dependency management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rkundam
approved these changes
Feb 13, 2026
mneethiraj
added a commit
that referenced
this pull request
Feb 13, 2026
(cherry picked from commit ca244f6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?