-
Notifications
You must be signed in to change notification settings - Fork 197
CI: add NOTICE year and binaries check to Apache RAT check #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Add check for current year in NOTICE file copyright statement - Ensure copyright year is up-to-date (eg, 2024-$currentyear) * Add binary files detection in source tree - This check is inspired by Apache MADlib's rat-check script. - Check for common binary extensions (class, jar, tar, tgz, zip, exe, dll, so) * Improve workflow output and reporting - Add structured console output for both checks - Include check results in GitHub Actions job summary
|
We have a few files in the Should we delete them for better ASF compliance? |
./gpMgmt/demo/gppkg/sample-sources.tar.gz - vote for delete it As for others, maybe we should launch gpfdist and contrib/formatter_fixedwidth regress tests, and check if it is needed for regress tests or not. If not, let's delete it |
b309204 to
c367e07
Compare
There is a discussion on the mailing list - https://lists.apache.org/thread/zcb0xcxxl28ckqqj24r68jnr7g7t52kx. We can keep them for now. Also, added the notice for them - #1454. |
c367e07 to
60a01d0
Compare
|
Will rebase once #1528 is merged. |
Add check for current year in NOTICE file copyright statement
Add binary files detection in source tree
Improve workflow output and reporting
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions