-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI Add comprehensive domain deletion confirmation dialog (Feature Request #11497) #12380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
Implements a confirmation modal for domain deletion that shows detailed impact before proceeding, making it consistent with account deletion
|
@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@DaanHoogland WDYT? |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@Imvedansh , I moved it to 4.20 as this is the oldest supported LTS. |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12380 +/- ##
============================================
+ Coverage 4.28% 15.17% +10.88%
- Complexity 0 11366 +11366
============================================
Files 372 5416 +5044
Lines 29745 476130 +446385
Branches 5229 58139 +52910
============================================
+ Hits 1275 72243 +70968
- Misses 28324 395796 +367472
- Partials 146 8091 +7945
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
I was working on
Yeah , was thinking same. |
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need update for async deleteDomain (try deleting a domain which has an account)
| confirmDeleteDomain () { | ||
| const params = { id: this.deleteDomainResource.id } | ||
| api('deleteDomain', params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Imvedansh deleteDomain is an async API. You would mostly always get a 200 response as it would return the jobid. So you'll have to poll that job ID instead showing success immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, alrightyy.
I ll shoot changes shortly
Implements a confirmation modal for domain deletion that shows detailed impact before proceeding, making it consistent with account deletion
Description
This PR implements a comprehensive domain deletion confirmation dialog, making the domain deletion process consistent with account deletion and providing better warnings to users about the impact of their actions.
Fixes #11497
New Component: DomainDeleteConfirm
listAccountsandlistVirtualMachinesAPIsTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?