fix: replace() returns wrong result for empty-string search#3391
Open
wattt3 wants to merge 1 commit intoapache:mainfrom
Open
fix: replace() returns wrong result for empty-string search#3391wattt3 wants to merge 1 commit intoapache:mainfrom
wattt3 wants to merge 1 commit intoapache:mainfrom
Conversation
andygrove
reviewed
Feb 4, 2026
| } | ||
| } | ||
|
|
||
| test("replace with empty search string") { |
Member
There was a problem hiding this comment.
Could you add these tests in the new sql file testing approach instead?
https://datafusion.apache.org/comet/contributor-guide/sql-file-tests.html
Member
|
Thanks @wattt3. LGTM. I left a comment about moving the tests to the new sql file based approach. I will be happy to approve the PR once that is done. |
Member
|
There is a test failure: |
Author
|
Hi @andygrove, thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Which issue does this PR close?
Closes #3344.
Rationale for this change
What changes are included in this PR?
How are these changes tested?