Skip to content

minor: map_from_entries sql tests#3394

Open
kazantsev-maksim wants to merge 23 commits intoapache:mainfrom
kazantsev-maksim:map_from_entries_sql_tests
Open

minor: map_from_entries sql tests#3394
kazantsev-maksim wants to merge 23 commits intoapache:mainfrom
kazantsev-maksim:map_from_entries_sql_tests

Conversation

@kazantsev-maksim
Copy link
Contributor

Which issue does this PR close?

N/A

Rationale for this change

Part of: #3328

What changes are included in this PR?

SQL-file tests have been added for the map_from_entries function.

How are these changes tested?

query expect_fallback(Using BinaryType as Map values is not allowed in map_from_entries)
SELECT map_from_entries(array(struct(10, cast('x' as binary))))

query spark_answer_only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be nice to have a comment explaining why spark_answer_only is needed

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants