You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So auto == native_iceberg_compat IIUC Will this cause to slip some bugs in the future?
Correct, auto is currently the same as native_iceberg_compat. The main change with this PR is that we no longer test with native_datafusion, so it is possible that we could introduce changes that mean we fall back to Spark for some operator when native_datafusion is enabled and not notice that.
However, the plan is for auto mode to eventually choose between native_datafusion and native_iceberg_compat, so we would catch any regressions once this happens.
Note that the worst case scenario here is not missing any kind of correctness issue. This test suite does not run any queries. It just checks that the plan is expected.
The main change with this PR is that we no longer test with native_datafusion
I'm prob not getting this. native_datafusion is supported, why not longer test? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?