Skip to content

chore: 9x reduction in number of golden files#3399

Open
andygrove wants to merge 3 commits intoapache:mainfrom
andygrove:fewer-golden-files
Open

chore: 9x reduction in number of golden files#3399
andygrove wants to merge 3 commits intoapache:mainfrom
andygrove:fewer-golden-files

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Feb 5, 2026

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

  • only generate golden files for the default scan mode (auto) - drop native_datafusion and native_iceberg_compat
  • only generate extended explain plan - drop simplified and regular explain plan

How are these changes tested?

@kazuyukitanimura
Copy link
Contributor

So auto == native_iceberg_compat IIUC
Will this cause to slip some bugs in the future?

@andygrove
Copy link
Member Author

So auto == native_iceberg_compat IIUC Will this cause to slip some bugs in the future?

Correct, auto is currently the same as native_iceberg_compat. The main change with this PR is that we no longer test with native_datafusion, so it is possible that we could introduce changes that mean we fall back to Spark for some operator when native_datafusion is enabled and not notice that.

However, the plan is for auto mode to eventually choose between native_datafusion and native_iceberg_compat, so we would catch any regressions once this happens.

Note that the worst case scenario here is not missing any kind of correctness issue. This test suite does not run any queries. It just checks that the plan is expected.

@andygrove andygrove marked this pull request as ready for review February 5, 2026 15:20
@comphead
Copy link
Contributor

comphead commented Feb 5, 2026

The main change with this PR is that we no longer test with native_datafusion

I'm prob not getting this. native_datafusion is supported, why not longer test? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants