Open
Conversation
Contributor
|
Thank you for the contribution @YutaLin! Could you add/migrate the expression tests to the new SQL test framework? https://datafusion.apache.org/comet/contributor-guide/sql-file-tests.html |
cb61473 to
379180e
Compare
Author
|
Hi @mbutrovich, thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3131
Rationale for this change
Comet does not currently support the Spark years function, causing queries using this function to fall back to Spark's JVM execution instead of running natively on DataFusion.
This patch adds serialization support for
Years, allowing Comet to recognize the expressionWhat changes are included in this PR?
Yearsexpression to DataFusion `datepart('year, child)' and cast to integergetSupportLevelto restrict support typeDateType,TimestampTypeandTimestampNTZTypeQueryPlanSerdeHow are these changes tested?
CometExpressionSerdeto verifyYearsexpression is identified correctly and serialized into Protobuf message.getSupportLevelreturnsCompatiblefor supported temporal types.