feat: Implement Spark functions hour, minute, second #19512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Dec 27, 2025
| )]), | ||
| TypeSignature::Exact(vec
Jefffrey
reviewed
Dec 27, 2025
|
|
||
| /// Creates a signature for datetime extraction functions that accept timestamp types. | ||
| fn extract_signature() -> Signature { | ||
| Signature::one_of( |
Contributor
There was a problem hiding this comment.
Can use this signature:
Signature::coercible(vec![Coercion::new_exact(TypeSignatureClass::Timestamp)], Volatility::Immutable)Accepts any timestamp type with any timezone (or no timezone)
Jefffrey
approved these changes
Dec 29, 2025
Contributor
|
Took the liberty of fixing CI & merging up from main to get this good to merge |
Contributor
|
Thanks @andygrove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Add new functions: hour, minute, and second.
What changes are included in this PR?
Are these changes tested?
Yes, tests added as part of this PR.
Are there any user-facing changes?
No, these are new functions.