docs: fix typos in PartitionEvaluator trait documentation #19631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two documentation issues in partition_evaluator.rs: 1. Remove extraneous 'x' character from evaluate method doc comment - "partition.x" → "partition." 2. Correct RANK example to show proper SQL RANK behavior - Ties should have the same rank value - "D | 5" → "D | 4" Closes apache#11700
Jefffrey
approved these changes
Jan 4, 2026
Contributor
|
Thanks @SolariSystems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11700
Rationale for this change
The documentation for the
PartitionEvaluatortrait contains two typos that could confuse readers.What changes are included in this PR?
Line 178: Removed extraneous 'x' character from the
evaluatemethod documentationpartition.xtopartition.Line 213: Corrected the RANK example to show proper SQL RANK behavior
D | 5toD | 4Are these changes tested?
Documentation-only change - no code affected.
Are there any user-facing changes?
No, documentation only.