test: Add unit tests for utility classes #756

bengbengbalabalabeng · 2025-12-25T14:31:26Z

Purpose of the pull request

Add unit tests for utility classes in fesod-common module.

Checklist

I have read the Contributor Guide.
I have written the necessary doc or comment.
I have added the necessary unit tests and all cases have passed.

Copilot

Pull request overview

This PR adds comprehensive unit tests for utility classes in the fesod-common module, enhancing test coverage across multiple utility classes including validation, string manipulation, collection utilities, I/O operations, and more.

Adds unit tests for 9 utility classes (ValidateUtils, StringUtils, PositionUtils, MemberUtils, MapUtils, ListUtils, IoUtils, IntUtils, BooleanUtils)
Includes comprehensive test cases covering edge cases, error conditions, and normal operations
Changes StringUtilsTest class visibility from public to package-private for consistency

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
ValidateUtilsTest.java	New test file covering validation utility methods including isTrue and notNull with various parameter types
StringUtilsTest.java	Enhanced test file with comprehensive tests for string operations (isEmpty, isBlank, equals, isNumeric, regionMatches) and visibility change
PositionUtilsTest.java	New test file for position/cell reference utilities with tests for row and column extraction
MemberUtilsTest.java	New test file for reflection utility methods testing access modifier checks and accessibility workarounds
MapUtilsTest.java	New test file for map creation utilities testing HashMap, TreeMap, LinkedHashMap factory methods and capacity calculations
ListUtilsTest.java	New test file for list utilities covering ArrayList creation from various sources and capacity management
IoUtilsTest.java	New test file for I/O operations testing byte array conversion and stream copying functionality
IntUtilsTest.java	New test file for integer utilities testing saturated casting from long to int
BooleanUtilsTest.java	New test file for boolean utilities testing various boolean checking methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-05T12:52:13Z

fesod-common/src/test/java/org/apache/fesod/common/util/PositionUtilsTest.java

+    void test_getRowByRowTagt() {
+        Assertions.assertEquals(0, PositionUtils.getRowByRowTagt("1", null));
+        Assertions.assertEquals(9, PositionUtils.getRowByRowTagt("10", 5));
+        Assertions.assertEquals(6, PositionUtils.getRowByRowTagt(null, 5));
+        Assertions.assertEquals(0, PositionUtils.getRowByRowTagt(null, null));


The method name contains a typo: "getRowByRowTagt" should be "getRowByRowTag" (without the extra 't' at the end).

Suggested change

void test_getRowByRowTagt() {

Assertions.assertEquals(0, PositionUtils.getRowByRowTagt("1", null));

Assertions.assertEquals(9, PositionUtils.getRowByRowTagt("10", 5));

Assertions.assertEquals(6, PositionUtils.getRowByRowTagt(null, 5));

Assertions.assertEquals(0, PositionUtils.getRowByRowTagt(null, null));

void test_getRowByRowTag() {

Assertions.assertEquals(0, PositionUtils.getRowByRowTag("1", null));

Assertions.assertEquals(9, PositionUtils.getRowByRowTag("10", 5));

Assertions.assertEquals(6, PositionUtils.getRowByRowTag(null, 5));

Assertions.assertEquals(0, PositionUtils.getRowByRowTag(null, null));

Copilot · 2026-01-05T12:52:14Z

fesod-common/src/test/java/org/apache/fesod/common/util/PositionUtilsTest.java

+    void test_getRowByRowTagt() {
+        Assertions.assertEquals(0, PositionUtils.getRowByRowTagt("1", null));
+        Assertions.assertEquals(9, PositionUtils.getRowByRowTagt("10", 5));
+        Assertions.assertEquals(6, PositionUtils.getRowByRowTagt(null, 5));
+        Assertions.assertEquals(0, PositionUtils.getRowByRowTagt(null, null));


The method calls contain a typo: "getRowByRowTagt" should be "getRowByRowTag" (without the extra 't' at the end). This appears multiple times and should match the actual utility method name being tested.

Suggested change

void test_getRowByRowTagt() {

Assertions.assertEquals(0, PositionUtils.getRowByRowTagt("1", null));

Assertions.assertEquals(9, PositionUtils.getRowByRowTagt("10", 5));

Assertions.assertEquals(6, PositionUtils.getRowByRowTagt(null, 5));

Assertions.assertEquals(0, PositionUtils.getRowByRowTagt(null, null));

void test_getRowByRowTag() {

Assertions.assertEquals(0, PositionUtils.getRowByRowTag("1", null));

Assertions.assertEquals(9, PositionUtils.getRowByRowTag("10", 5));

Assertions.assertEquals(6, PositionUtils.getRowByRowTag(null, 5));

Assertions.assertEquals(0, PositionUtils.getRowByRowTag(null, null));

Copilot · 2026-01-05T12:52:14Z

fesod-common/src/test/java/org/apache/fesod/common/util/MemberUtilsTest.java

+import org.junit.jupiter.api.Test;
+
+/**
+ * Tests {@link MemberUtilsTest}


The JavaDoc comment incorrectly references "MemberUtilsTest" instead of "MemberUtils". The comment should reference the class being tested, not the test class itself.

Suggested change

* Tests {@link MemberUtilsTest}

* Tests {@link MemberUtils}

Copilot · 2026-01-05T12:52:14Z

fesod-common/src/test/java/org/apache/fesod/common/util/StringUtilsTest.java

+        }
+    }
+
+    static class TestData {


The visibility modifier of the TestData class should be "private static" instead of just "static". The class is only used internally within this test class and should follow proper encapsulation principles.

Suggested change

static class TestData {

private static class TestData {

Copilot · 2026-01-05T12:52:15Z

fesod-common/src/test/java/org/apache/fesod/common/util/ValidateUtilsTest.java

+
+    @Test
+    void test_isTrue() {
+        Assertions.assertDoesNotThrow(() -> ValidateUtils.isTrue(1 + 1 == 2));


Test is always true.

delei · 2026-01-05T12:57:10Z

Hi @bengbengbalabalabeng
This is not necessary, but I still recommend that you refer to the suggestions provided by it to improve the code :)

bengbengbalabalabeng · 2026-01-05T13:38:56Z

This is not necessary, but I still recommend that you refer to the suggestions provided by it to improve the code :)

Thanks for the review. I've applied. 😊

delei · 2026-01-05T13:48:21Z

fesod-common/src/test/java/org/apache/fesod/common/util/PositionUtilsTest.java

+
+    @Test
+    void test_getCol() {
+        Assertions.assertEquals(0, PositionUtils.getCol("A1", null)); // A -> 0


It is not recommended to use end-of-line comments in the code.

delei

LGTM

bengbengbalabalabeng and others added 5 commits December 25, 2025 22:25

test: add unit tests for utility classes

21c2dd4

Merge branch 'main' into add-common-tests

6a0602a

Merge branch 'main' into add-common-tests

0a5a3cd

Merge branch 'main' into add-common-tests

606da29

Merge branch 'main' into add-common-tests

ff312ac

delei requested a review from Copilot January 5, 2026 12:49

Copilot started reviewing on behalf of delei January 5, 2026 12:49 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

test: apply suggestions and clean up test code

b5e3aa1

delei requested changes Jan 5, 2026

View reviewed changes

style(test): normalize comment formatting

fdb4049

delei approved these changes Jan 5, 2026

View reviewed changes

delei merged commit d713131 into apache:main Jan 5, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: Add unit tests for utility classes #756

test: Add unit tests for utility classes #756

bengbengbalabalabeng commented Dec 25, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

delei commented Jan 5, 2026

Uh oh!

bengbengbalabalabeng commented Jan 5, 2026

Uh oh!

delei Jan 5, 2026

Uh oh!

bengbengbalabalabeng Jan 5, 2026

Uh oh!

delei left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

test: Add unit tests for utility classes #756

test: Add unit tests for utility classes #756

Conversation

bengbengbalabalabeng commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of the pull request

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

delei commented Jan 5, 2026

Uh oh!

bengbengbalabalabeng commented Jan 5, 2026

Uh oh!

delei Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

bengbengbalabalabeng Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

delei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bengbengbalabalabeng commented Dec 25, 2025 •

edited

Loading