Only delete data, but don't delete tsfile when performing a drop column statement on the table model or a drop tag statement on the tree model #16936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can't rename file successfully.
…mn statement on the table model or a drop tag statement on the tree model.
…ement on table model.
zerolbsony
force-pushed
the
improve_optimize_delete_tsfile
branch
from
b6ef768 to
8b91c88
Compare
jt2594838
reviewed
Dec 25, 2025
integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBDeletionIT.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/modification/DeletionPredicate.java
…ot NOP when delete table data by tag.
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
jt2594838
approved these changes
Jan 6, 2026
… statistics in current chunk metadata so that resolve "Statistics classes mismatched: class org.apache.tsfile.file.metadata.statistics.BinaryStatistics vs. class org.apache.tsfile.file.metadata.statistics.IntegerStatistics" exception.
jt2594838
requested changes
Jan 9, 2026
Comment on lines
+452
to
+462
| if (chunkMetadata.getDataType() == TSDataType.BOOLEAN) { | ||
| binaryValues[2] = new Binary(Boolean.FALSE.toString(), StandardCharsets.UTF_8); | ||
| binaryValues[3] = new Binary(Boolean.TRUE.toString(), StandardCharsets.UTF_8); | ||
| } else { | ||
| binaryValues[2] = | ||
| new Binary( | ||
| chunkMetadata.getStatistics().getMinValue().toString(), StandardCharsets.UTF_8); | ||
| binaryValues[3] = | ||
| new Binary( | ||
| chunkMetadata.getStatistics().getMaxValue().toString(), StandardCharsets.UTF_8); | ||
| } |
Contributor
There was a problem hiding this comment.
No need to process DATE especially?
Comment on lines
+495
to
+499
| Arrays.asList(TSDataType.TEXT, TSDataType.BLOB) | ||
| .contains(chunkMetadata.getDataType()) | ||
| ? "" | ||
| : chunkMetadata.getStatistics().getMinValue().toString(), | ||
| StandardCharsets.UTF_8); |
Contributor
There was a problem hiding this comment.
Why are you checking the data type of the chunk metadata again, now that it is in the switch clause?
Comment on lines
+519
to
+520
| binaryValues[0] = new Binary("", StandardCharsets.UTF_8); | ||
| binaryValues[1] = new Binary("", StandardCharsets.UTF_8); |
Contributor
There was a problem hiding this comment.
May creaete a constant as a placeholder for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only delete data, but don't delete tsfile when performing a drop column statement on the table model or a drop tag statement on the tree model.