[python] support ray data sink to paimon #6883
Open
+143
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from pypaimon.write.ray_datasink import PaimonDatasink | ||
| datasink = PaimonDatasink(dataset, overwrite=overwrite) | ||
| dataset.write_datasink(datasink, concurrency=parallelism) | ||
|
|
Contributor
There was a problem hiding this comment.
we can named it as write_ray, just list write_pandas, write_arrow and so on
| table_write = self.writer_builder.new_write() | ||
| for block in blocks: | ||
| block_arrow: pa.Table = BlockAccessor.for_block(block).to_arrow() | ||
| table_write.write_arrow(block_arrow) |
Contributor
There was a problem hiding this comment.
I am afraid to_arrow will cost a lot of memory, we can introduce some stream or iterable way.
| staging bucket in S3. | ||
| """ | ||
| self.writer_builder: WriteBuilder= self.table.new_batch_write_builder() | ||
| if self.overwrite: |
Contributor
There was a problem hiding this comment.
Could you please add test to show that writer_builder is serializable
| """ | ||
| table_commit = self.writer_builder.new_commit() | ||
| table_commit.commit([commit_message for commit_messages in write_result.write_returns for commit_message in commit_messages]) | ||
| table_commit.close() |
Contributor
There was a problem hiding this comment.
We should handle write failure case too.
| def write_raydata(self, dataset, overwrite=False, parallelism=1): | ||
| from pypaimon.write.ray_datasink import PaimonDatasink | ||
| datasink = PaimonDatasink(dataset, overwrite=overwrite) | ||
| dataset.write_datasink(datasink, concurrency=parallelism) |
Contributor
There was a problem hiding this comment.
provided dataset, but PaimonDatasink init method needs a table here
| return self | ||
|
|
||
| def write_raydata(self, dataset, overwrite=False, parallelism=1): | ||
| from pypaimon.write.ray_datasink import PaimonDatasink |
Contributor
There was a problem hiding this comment.
How can user get the dataset in non test mode code, can you add a sample code for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation