Skip to content

Conversation

@vinodkc
Copy link
Contributor

@vinodkc vinodkc commented Dec 25, 2025

What changes were proposed in this pull request?

This PR adds whole-stage code generation support for three KLL sketch functions:

  • kll_sketch_get_n_bigint
  • kll_sketch_get_n_float
  • kll_sketch_get_n_double

Why are the changes needed?

Currently, these functions use CodegenFallback, which causes them to fall back to interpreted interpreted evaluation, which is typically slower than generated code for operations processing millions of rows

Does this PR introduce any user-facing change?

No.

How was this patch tested?

All existing SQL tests pass

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant