-
Notifications
You must be signed in to change notification settings - Fork 845
ssl_multicert.config -> ssl_multicert.yaml #12755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bneradt
wants to merge
2
commits into
apache:11-Dev
Choose a base branch
from
bneradt:convert_ssl_multicert_config_to_remap
base: 11-Dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ssl_multicert.config -> ssl_multicert.yaml #12755
bneradt
wants to merge
2
commits into
apache:11-Dev
from
bneradt:convert_ssl_multicert_config_to_remap
+3,401
−465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b6767b to
4cb0241
Compare
10 tasks
145da27 to
72e817d
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 198 out of 198 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (3)
tests/gold_tests/tls/tls_check_dual_cert_selection.test.py:56
- The test is still using legacy format syntax in AddLines() after changing from ssl_multicert_config to ssl_multicert_yaml. Lines 53-56 contain legacy format entries like 'ssl_cert_name=signed-foo-ec.pem,signed-foo.pem' which should be converted to YAML format to match the migration pattern used consistently in other test files.
tests/gold_tests/tls/tls_check_cert_select_plugin.test.py:52 - Similar to tls_check_dual_cert_selection.test.py, this test is still using legacy format syntax after changing to ssl_multicert_yaml. Lines 49-52 should be converted to YAML format to be consistent with the migration pattern.
tests/gold_tests/tls/tls_check_cert_selection_reload.test.py:46 - This test is still using legacy format syntax in AddLines() after changing to ssl_multicert_yaml. Lines 44-46 contain legacy format entries which should be converted to YAML format for consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
brbzull0
reviewed
Dec 16, 2025
brbzull0
reviewed
Dec 16, 2025
Replace the ssl_multicert.config format with YAML format, following the pattern established by sni.yaml. The new ssl_multicert.yaml uses a top-level 'ssl_multicert' key containing a sequence of certificate entries. This also supports config conversion via: traffic_ctl config ssl_multicert <old_config> <new_config>
This also makes yaml the default traffic_ctl config ssl_multicert show format
3ad74ce to
63866b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the ssl_multicert.config format with YAML format, following the pattern established by sni.yaml. The new ssl_multicert.yaml uses a top-level 'ssl_multicert' key containing a sequence of certificate entries.
This also supports config conversion via:
Community Decisions
traffic_ctl config convertper @cmcfarlen 's suggestion.At least for ssl_multicert, either of these options are possible from an implementation standpoint.
@cmcfarlen had an interesting suggestion to bake the config conversion logic into traffic_ctl. Maybe have something like: