Skip to content

Conversation

@vdusek
Copy link
Contributor

@vdusek vdusek commented Feb 11, 2026

Summary

  • test_get_env_with_randomized_env_vars was overriding APIFY_LOCAL_STORAGE_DIR with a random 10-char string (e.g. KAHL8QER2W), causing Actor.init() to create a leftover storage directory in the project root on every test run
  • Excluded LOCAL_STORAGE_DIR from randomization and set the expected value to the tmp_path provided by the _isolate_test_environment fixture

Test plan

  • uv run poe lint passes
  • uv run poe unit-tests passes (249 tests)
  • No leftover directories created in the project root after test run

🤖 Generated with Claude Code

The test_get_env_with_randomized_env_vars test was overriding
APIFY_LOCAL_STORAGE_DIR with a random 10-char string, causing
Actor.init() to create a storage directory in the project root.

Exclude LOCAL_STORAGE_DIR from randomization and use the tmp_path
value set by the _isolate_test_environment fixture instead.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@github-actions github-actions bot added this to the 134th sprint - Tooling team milestone Feb 11, 2026
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.02%. Comparing base (56cfc38) to head (c2af53c).
⚠️ Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (56cfc38) and HEAD (c2af53c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (56cfc38) HEAD (c2af53c)
integration 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #779       +/-   ##
===========================================
- Coverage   81.86%   68.02%   -13.84%     
===========================================
  Files          46       46               
  Lines        2696     2696               
===========================================
- Hits         2207     1834      -373     
- Misses        489      862      +373     
Flag Coverage Δ
integration ?
unit 68.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek added the adhoc Ad-hoc unplanned task added during the sprint. label Feb 11, 2026
@vdusek vdusek merged commit cf36cc2 into master Feb 11, 2026
26 of 30 checks passed
@vdusek vdusek deleted the fix/test-env-helpers-storage-dir-leak branch February 11, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant