Skip to content

Handle NS record flow and auto-verification of sub-domains #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hmacr merged 10 commits into from
Jan 14, 2026
Merged

Handle NS record flow and auto-verification of sub-domains #2784

hmacr merged 10 commits into from
Jan 14, 2026

Conversation

@hmacr
Copy link
Contributor

@hmacr hmacr commented Jan 13, 2026 •
edited by coderabbitai bot
Loading

Closes SER-720
Closes SER-90

Summary by CodeRabbit

  • New Features

    • More granular domain verification statuses with distinct badges and messaging
    • Automatic nameserver updates for matching apex domains during verification attempts
    • Domain lists can be passed into retry flows for improved lookups

  • Bug Fixes

    • Improved error handling and clearer success/error notifications during creation and verification
    • More consistent cache invalidation and navigation after verification
    • DNS guidance clarified: "DNS changes may take up to 48 hours to propagate fully."

  • Refactor

    • Verification views/components now accept a ruleStatus prop and propagate it to related tables
    • Record name cell became interactive for easier copying

  • Style

    • Badge severity and sizing adjusted for failed verification and "Not verified" states

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026 •
edited
Loading

Walkthrough

NameserverTable’s exported props were restructured from two separate bindings to a single destructured $props() object and now includes an optional ruleStatus?: 'created' | 'verifying' | 'unverified' | 'verified'. Its badge rendering was expanded to handle multiple ruleStatus values and an undefined verified state. Multiple add-domain, verify, and retry flows across functions, sites, and settings were refactored to use getApexDomain, optionally update cloud nameservers when an apex domain exists, move cache invalidation earlier, and treat any non-'created' rule status as verified. retryDomainModal and several table usages now accept or pass an optional domainsList. Various UI text/badge type adjustments add "DNS" and change some failure badges to error.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: handling NS record flow and enabling auto-verification of sub-domains, which aligns with the core refactoring across domain verification components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

🧹 Recent nitpick comments
src/lib/components/domains/recordTable.svelte (1)

118-120: Good UX improvement — but CAA row is inconsistent.

Using InteractiveText for the Name cell aligns nicely with the Value column behavior and improves usability. However, the CAA row at line 133 still renders plain text @ for its Name cell, creating an inconsistency in copy behavior.

♻️ Optional: Apply InteractiveText to CAA row for consistency 
-                <Table.Cell column="name" {root}>@</Table.Cell>
+                <Table.Cell column="name" {root}>
+                    <InteractiveText variant="copy" isVisible text="@" />
+                </Table.Cell>
src/lib/components/domains/nameserverTable.svelte (1)

26-40: Consider handling ruleStatus === 'verified' explicitly or removing it from the type.

The ruleStatus type includes 'verified' but there's no explicit branch for it. Currently, it falls through to verified === true, which works only if both props are always consistent. If someone passes ruleStatus='verified' with verified=false, no badge renders.

Either:

  1. Add an explicit {:else if ruleStatus === 'verified'} branch, or
  2. Remove 'verified' from the ruleStatus type since the boolean verified prop already handles the success state
Option 1: Add explicit handling 
             {:else if ruleStatus === 'unverified'}
                 <Badge
                     variant="secondary"
                     type="error"
                     size="xs"
                     content="Certificate generation failed" />
-            {:else if verified === true}
+            {:else if ruleStatus === 'verified' || verified === true}
                 <Badge variant="secondary" type="success" size="xs" content="Verified" />
             {/if}
Option 2: Remove 'verified' from ruleStatus type 
     let {
         domain,
         verified,
         ruleStatus
     }: {
         domain: string;
         verified?: boolean;
-        ruleStatus?: 'created' | 'verifying' | 'unverified' | 'verified';
+        ruleStatus?: 'created' | 'verifying' | 'unverified';
     } = $props();
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9d318c and c78a85d.

📒 Files selected for processing (2)
  • src/lib/components/domains/nameserverTable.svelte
  • src/lib/components/domains/recordTable.svelte
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,js,jsx,svelte}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,svelte}: Import reusable modules from the src/lib directory using the $lib alias
Use minimal comments in code; reserve comments for TODOs or complex logic explanations
Use $lib, $routes, and $themes aliases instead of relative paths for module imports

Files:

  • src/lib/components/domains/recordTable.svelte
  • src/lib/components/domains/nameserverTable.svelte
src/lib/components/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use PascalCase for component file names and place them in src/lib/components/[feature]/ directory structure

Files:

  • src/lib/components/domains/recordTable.svelte
  • src/lib/components/domains/nameserverTable.svelte
**/*.{ts,tsx,js,jsx,svelte,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use 4 spaces for indentation, single quotes, 100 character line width, and no trailing commas per Prettier configuration

Files:

  • src/lib/components/domains/recordTable.svelte
  • src/lib/components/domains/nameserverTable.svelte
**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use Svelte 5 + SvelteKit 2 syntax with TypeScript for component development

Files:

  • src/lib/components/domains/recordTable.svelte
  • src/lib/components/domains/nameserverTable.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: e2e
🔇 Additional comments (2)
src/lib/components/domains/recordTable.svelte (1)

15-33: LGTM - Cleanup of unnecessary defaults.

Removing explicit = undefined from optional props is appropriate since TypeScript optional properties default to undefined anyway. No behavioral change.

src/lib/components/domains/nameserverTable.svelte (1)

6-14: LGTM!

Props are correctly structured using Svelte 5's $props() pattern with proper TypeScript typing. The optional props have no unnecessary defaults, which addresses the previous review feedback.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte (1)

162-163: Missing ruleStatus prop on NameserverTable.

The NameserverTable here only receives domain and verified, but the functions verify page (and other usages in this PR) also pass ruleStatus={data.proxyRule.status}. This inconsistency will cause different badge rendering behavior.

Suggested fix 
-                        <NameserverTable domain={data.proxyRule.domain} {verified} />
+                        <NameserverTable
+                            domain={data.proxyRule.domain}
+                            {verified}
+                            ruleStatus={data.proxyRule.status} />
🤖 Fix all issues with AI agents 
In
@src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte:
- Around line 80-83: The invalidate calls after awaiting goto(routeBase) can
fail because the component may unmount; move the invalidation to before
navigation by calling invalidate(Dependencies.DOMAINS) and
invalidate(Dependencies.FUNCTION_DOMAINS) prior to awaiting goto(routeBase) so
the invalidations run in the current component context (keep the same Dependency
constants and routeBase variable).

In
@src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte:
- Around line 63-65: The catch block currently uses the parameter name "error",
which shadows the component's "error" state variable (declared earlier) and
prevents updating it; rename the catch parameter to something like "err" or
"caughtError", update any references inside that catch block to the new name,
and if the intent was to record the failure set the component state "error"
(e.g., error = String(err) or error = err.message) instead of ignoring it so the
component state is not shadowed.

In
@src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte:
- Around line 41-50: In the catch block handling domain add failures (the
try/catch around the add-domain flow), make the error handling consistent by
guarding access to error.message with optional chaining and a safe fallback;
replace direct use of error.message with error?.message || String(error) (or
similar) and ensure the alreadyAdded check remains error?.type ===
'domain_already_exists' so you won’t throw if error is null/undefined.

In
@src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte:
- Around line 80-82: The code calls await goto(routeBase) before await
invalidate(Dependencies.DOMAINS), which can unmount the page before cache is
refreshed; move the await invalidate(Dependencies.DOMAINS) call to before await
goto(routeBase) so Dependencies.DOMAINS is invalidated while the current
component is still mounted (update the sequence in the function that performs
navigation so invalidate(...) runs prior to goto(routeBase)).

In
@src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte:
- Around line 63-65: The catch block is shadowing the component state variable
named error; rename the catch parameter (e.g., from error to err or ex) in
retryDomainModal.svelte so you don't mask the component's error state, and if
you need to inspect or log the thrown exception use the new name (err) while
leaving the component-level error variable unchanged.
🧹 Nitpick comments (4)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte (1)

69-78: Consider defensive access for error.message.

If error is truthy but lacks a message property, the notification would display undefined. Consider using optional chaining or a fallback.

💡 Suggested improvement 
                 if (!alreadyAdded) {
                     addNotification({
                         type: 'error',
-                        message: error.message
+                        message: error?.message ?? 'Failed to create apex domain'
                     });
                     return;
                 }
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte (2)

59-68: Consistent optional chaining on error object.

Line 61 uses optional chaining (error?.type) but line 65 accesses error.message directly. While unlikely to be undefined here, consider using error?.message for consistency.

                     addNotification({
                         type: 'error',
-                        message: error.message
+                        message: error?.message ?? 'Failed to create apex domain'
                     });

100-112: Defensive check for undefined rule.

If rule is undefined (unlikely but possible if behaviour has an unexpected value), rule?.status !== 'created' would evaluate to true, incorrectly treating the domain as verified.

Suggested defensive improvement 
-            const verified = rule?.status !== 'created';
+            const verified = rule && rule.status !== 'created';
             if (verified) {
src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte (1)

63-65: Variable shadowing: error parameter shadows component state.

The catch (error) on line 63 shadows the error state variable declared on line 45. While the error is intentionally ignored here, this shadowing could cause confusion or unintended behavior if the code is modified later.

Suggested fix 
-        } catch (error) {
+        } catch {
             // Ignore error
         }
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da326f8 and e9bf601.

📒 Files selected for processing (13)
  • src/lib/components/domains/nameserverTable.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx,js,jsx,svelte}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,svelte}: Import reusable modules from the src/lib directory using the $lib alias
Use minimal comments in code; reserve comments for TODOs or complex logic explanations
Use $lib, $routes, and $themes aliases instead of relative paths for module imports

Files:

  • src/routes/(console)/project-[region]-[project]/settings/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/lib/components/domains/nameserverTable.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
src/routes/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Files:

  • src/routes/(console)/project-[region]-[project]/settings/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
**/*.{ts,tsx,js,jsx,svelte,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use 4 spaces for indentation, single quotes, 100 character line width, and no trailing commas per Prettier configuration

Files:

  • src/routes/(console)/project-[region]-[project]/settings/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/lib/components/domains/nameserverTable.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use Svelte 5 + SvelteKit 2 syntax with TypeScript for component development

Files:

  • src/routes/(console)/project-[region]-[project]/settings/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/lib/components/domains/nameserverTable.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
src/routes/**

📄 CodeRabbit inference engine (AGENTS.md)

Configure dynamic routes using SvelteKit convention with [param] syntax in route directory names

Files:

  • src/routes/(console)/project-[region]-[project]/settings/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
src/lib/components/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use PascalCase for component file names and place them in src/lib/components/[feature]/ directory structure

Files:

  • src/lib/components/domains/nameserverTable.svelte
🧠 Learnings (5)
📓 Common learnings 
Learnt from: vermakhushboo
Repo: appwrite/console PR: 2364
File: src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte:52-89
Timestamp: 2025-09-24T10:27:36.797Z
Learning: In sites domain verification flows, domain creation should be handled in the background using promise chains (.then/.catch) with silent error handling, not awaited synchronously. This prevents domain creation failures from interrupting the main verification flow.
📚 Learning: 2025-09-24T10:27:36.797Z 
Learnt from: vermakhushboo
Repo: appwrite/console PR: 2364
File: src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte:52-89
Timestamp: 2025-09-24T10:27:36.797Z
Learning: In sites domain verification flows, domain creation should be handled in the background using promise chains (.then/.catch) with silent error handling, not awaited synchronously. This prevents domain creation failures from interrupting the main verification flow.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
📚 Learning: 2025-12-05T09:24:15.846Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2670
File: src/routes/(console)/organization-[organization]/+layout.ts:134-150
Timestamp: 2025-12-05T09:24:15.846Z
Learning: In the Appwrite console codebase, `prefs.organization` is maintained to always reference an organization with Platform.Appwrite, so when using preferences.organization as a fallback in redirect logic, no additional platform validation is required.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
📚 Learning: 2025-10-13T05:13:54.542Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2413
File: src/routes/(console)/project-[region]-[project]/databases/table.svelte:33-39
Timestamp: 2025-10-13T05:13:54.542Z
Learning: In Svelte 5, `import { page } from '$app/state'` provides a reactive state proxy that can be accessed directly (e.g., `page.params`), unlike the older `import { page } from '$app/stores'` which returns a readable store requiring the `$page` syntax for auto-subscription in components.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
📚 Learning: 2025-11-25T03:15:27.539Z 
Learnt from: CR
Repo: appwrite/console PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T03:15:27.539Z
Learning: Applies to src/routes/**/*.svelte : Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Applied to files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: e2e
🔇 Additional comments (16)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte (2)

61-61: LGTM!

Using const is appropriate since domain is only used for the existence check and is never reassigned.

110-122: LGTM!

The refactored flow correctly:

  1. Invalidates domain data before status evaluation to ensure fresh state.
  2. Uses rule status to determine verification need, avoiding unnecessary verification pages for already-verified domains.
  3. Provides appropriate user feedback based on verification state.
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte (1)

163-167: LGTM!

The NameserverTable usage correctly passes the new ruleStatus prop alongside verified and domain, aligning with the updated component API.

src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte (1)

135-149: LGTM!

The NameserverTable and RecordTable components correctly receive the ruleStatus prop and navigation callbacks, enabling proper state-driven rendering.

src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/table.svelte (1)

224-226: LGTM!

The domainsList prop is correctly passed to RetryDomainModal, enabling apex domain lookups for nameserver updates in cloud environments.

src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte (1)

52-88: LGTM!

The retry flow correctly implements the two-step verification (nameserver update followed by rule verification), with appropriate success/error handling and cache invalidation.

src/lib/components/domains/nameserverTable.svelte (2)

26-40: Consider handling ruleStatus === 'verified' explicitly.

The badge logic checks verified === true after exhausting other ruleStatus values. If ruleStatus is 'verified' but verified is false (e.g., verification attempt failed on an already-verified domain), no badge renders. Consider whether showing the "Verified" badge based on ruleStatus === 'verified' is more appropriate.

             {:else if ruleStatus === 'unverified'}
                 <Badge
                     variant="secondary"
                     type="error"
                     size="xs"
                     content="Certificate generation failed" />
-            {:else if verified === true}
+            {:else if verified === true || ruleStatus === 'verified'}
                 <Badge variant="secondary" type="success" size="xs" content="Verified" />
             {/if}

6-14: LGTM!

The props API is well-structured with appropriate TypeScript typing. The ruleStatus union type clearly documents the expected state machine values.

src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte (2)

52-88: LGTM on the two-phase verification flow.

The structure correctly separates the optional nameserver update (with silent error handling) from the main rule verification. This aligns with the established pattern where domain-related operations should not interrupt the main verification flow. The verified state management (undefined → true/false) provides clear tri-state feedback to child components.

136-139: The ruleStatus prop is properly declared in the NameserverTable component with correct TypeScript typing ('created' | 'verifying' | 'unverified' | 'verified'). No changes required.

src/routes/(console)/project-[region]-[project]/settings/domains/table.svelte (1)

229-231: LGTM on wiring domainsList prop to RetryDomainModal.

The organizationDomains data is correctly passed to the modal, enabling the apex domain resolution flow for nameserver updates in cloud environments.

src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte (1)

224-226: LGTM - consistent with settings domain table.

The domainsList prop is correctly wired to the modal, maintaining consistency with the parallel implementation in the settings domains table.

src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/+page.svelte (1)

54-70: LGTM on the streamlined domain creation and verification flow.

The logic correctly:

  1. Invalidates domain data before evaluating rule status
  2. Uses rule?.status !== 'created' to determine verification success
  3. Routes to verification page only when needed

This approach ensures the UI reflects the latest state before making navigation decisions.

src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte (3)

56-91: LGTM on the verification flow implementation.

The two-phase approach correctly:

  1. Attempts nameserver update silently (consistent with the learning that domain operations should not interrupt main flow)
  2. Handles rule verification with proper success/error notifications
  3. Manages the verified state for child component feedback

This aligns with the pattern established in retryDomainModal.svelte.

163-166: Consistent prop passing to NameserverTable.

The ruleStatus prop is correctly passed from data.proxyRule.status, matching the pattern used in other domain verification components.

58-59: data.domainsList is properly provided by the page loader.

The +page.ts loader (lines 15-27) fetches and returns domainsList with a guaranteed structure: either from the SDK or a fallback object with domains: []. No additional null checks are needed.

coderabbitai[bot]
coderabbitai bot reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte (1)

42-50: Add a safeguard to ensure selectedTab always corresponds to a visible tab.

In non-cloud deployments where all regional variables are missing or set to default values, getDefaultTab() returns 'nameserver' but the NS tab remains hidden since showNSTab is false. This creates a UI inconsistency where selectedTab points to an unavailable tab, and the NameserverTable content renders without a visible tab button.

Either initialize selectedTab to the first visible tab, or verify this configuration scenario cannot occur in practice.

🧹 Nitpick comments (4)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte (1)

81-86: Add type guard for error handling.

Accessing e.message on an unknown type may cause TypeScript issues in strict mode. Consider narrowing the type.

Suggested improvement 
         } catch (e) {
             verified = false;
-            error =
-                e.message ??
-                'Domain verification failed. Please check your domain settings or try again later';
+            error = e instanceof Error
+                ? e.message
+                : 'Domain verification failed. Please check your domain settings or try again later';
             trackError(e, Submit.DomainUpdateVerification);
         }
src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte (3)

18-26: Minor inconsistency: missing default value for show prop.

The show prop uses $bindable() without a default value, while the equivalent component in the sites directory uses $bindable(false). Consider adding a default for consistency.

Suggested fix 
     let {
-        show = $bindable(),
+        show = $bindable(false),
         selectedProxyRule,
         domainsList

81-86: Add type guard for error handling.

Same as the sites version—accessing e.message on an unknown type may cause TypeScript issues. Consider narrowing the type.

Suggested improvement 
         } catch (e) {
             verified = false;
-            error =
-                e.message ??
-                'Domain verification failed. Please check your domain settings or try again later';
+            error = e instanceof Error
+                ? e.message
+                : 'Domain verification failed. Please check your domain settings or try again later';
             trackError(e, Submit.DomainUpdateVerification);
         }

52-88: Consider extracting shared retry logic.

This component shares ~95% of its code with sites/site-[site]/domains/retryDomainModal.svelte. The only differences are the dependency constant (Dependencies.DOMAINS vs SITES_DOMAINS), the service prop value, and minor configuration. Consider extracting the shared retryDomain logic into a reusable helper to reduce duplication and ease future maintenance.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9bf601 and fcfa4c5.

📒 Files selected for processing (3)
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx,js,jsx,svelte}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,svelte}: Import reusable modules from the src/lib directory using the $lib alias
Use minimal comments in code; reserve comments for TODOs or complex logic explanations
Use $lib, $routes, and $themes aliases instead of relative paths for module imports

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
src/routes/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
**/*.{ts,tsx,js,jsx,svelte,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use 4 spaces for indentation, single quotes, 100 character line width, and no trailing commas per Prettier configuration

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use Svelte 5 + SvelteKit 2 syntax with TypeScript for component development

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
src/routes/**

📄 CodeRabbit inference engine (AGENTS.md)

Configure dynamic routes using SvelteKit convention with [param] syntax in route directory names

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
🧠 Learnings (2)
📚 Learning: 2025-10-21T06:07:53.455Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2477
File: src/routes/(console)/project-[region]-[project]/overview/platforms/llmBanner.svelte:27-38
Timestamp: 2025-10-21T06:07:53.455Z
Learning: In the Appwrite Console codebase, the `copy` helper utility (src/lib/helpers/copy.ts) already handles errors internally with try-catch blocks and returns a boolean success indicator. Additional error handling with try-catch is not needed when calling this utility.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
📚 Learning: 2025-09-24T10:27:36.797Z 
Learnt from: vermakhushboo
Repo: appwrite/console PR: 2364
File: src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte:52-89
Timestamp: 2025-09-24T10:27:36.797Z
Learning: In sites domain verification flows, domain creation should be handled in the background using promise chains (.then/.catch) with silent error handling, not awaited synchronously. This prevents domain creation failures from interrupting the main verification flow.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: e2e
🔇 Additional comments (9)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte (3)

18-26: Props structure is well-defined.

The addition of the optional domainsList prop and proper typing for selectedProxyRule is clean. The optional prop is correctly handled with ? in the type definition.

55-65: Apex domain pre-verification logic is sound.

The silent error handling for the nameserver update aligns with the established pattern where domain-related operations should not interrupt the main verification flow. Based on learnings, this is the correct approach.

135-150: Table components receive appropriate props.

The ruleStatus prop is correctly propagated to both NameserverTable and RecordTable, enabling proper UI signaling for domain verification status.

src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte (1)

135-150: Correct props for settings context.

The service="general" and Dependencies.DOMAINS correctly differentiate this component from the sites version. The ruleStatus prop is properly propagated.

src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte (5)

1-16: LGTM!

Imports are well-organized and use the $lib alias as per coding guidelines.

18-26: LGTM!

Props are well-typed with appropriate optionality for domainsList.

90-94: LGTM!

Good practice to clear the error state when the modal is closed, ensuring a clean slate on reopen.

135-150: LGTM!

The conditional rendering and prop passing to NameserverTable and RecordTable components is well-structured. The ruleStatus prop is consistently passed to both components for status-aware rendering.

52-88: API signature confirmed - updateNameservers accepts domainId object parameter.

The verification logic follows the established pattern across domain verification flows (sites, settings, organization). Silent error handling for the nameserver update prevents interrupting the main rule verification flow. Note that the learning suggests using promise chains (.then/.catch) instead of await for domain operations in background flows; however, this pattern is not currently implemented in the similar sites domain verification code either, suggesting it may be a future improvement target for consistency.

coderabbitai[bot]
coderabbitai bot reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte (1)

53-56: Placeholder link needs a valid URL.

The href="#" is a non-functional placeholder. Consider providing the actual documentation URL for domain providers and their DNS settings, or removing the link until it's available.

🤖 Fix all issues with AI agents 
In
`@src/routes/`(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte:
- Around line 113-122: The current check uses verified = rule?.status !==
'created' which treats undefined rule as verified; change the logic to first
explicitly check for rule existence (e.g., if (!rule) { addNotification({type:
'error', message: 'Domain verification info missing'}); await
goto(`${routeBase}/add-domain/verify-${domainName}`); return; }) and only then
compute verified from rule.status; update the branches that call addNotification
and await goto to use this new explicit rule check and preserve existing
behavior for addNotification, goto, routeBase, domainName and rule.$id.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fcfa4c5 and e93a775.

📒 Files selected for processing (5)
  • src/lib/components/domains/nameserverTable.svelte
  • src/routes/(console)/organization-[organization]/domains/recordsCard.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
✅ Files skipped from review due to trivial changes (1)
  • src/routes/(console)/organization-[organization]/domains/recordsCard.svelte
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx,js,jsx,svelte}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,svelte}: Import reusable modules from the src/lib directory using the $lib alias
Use minimal comments in code; reserve comments for TODOs or complex logic explanations
Use $lib, $routes, and $themes aliases instead of relative paths for module imports

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
  • src/lib/components/domains/nameserverTable.svelte
src/routes/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
**/*.{ts,tsx,js,jsx,svelte,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use 4 spaces for indentation, single quotes, 100 character line width, and no trailing commas per Prettier configuration

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
  • src/lib/components/domains/nameserverTable.svelte
**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use Svelte 5 + SvelteKit 2 syntax with TypeScript for component development

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
  • src/lib/components/domains/nameserverTable.svelte
src/routes/**

📄 CodeRabbit inference engine (AGENTS.md)

Configure dynamic routes using SvelteKit convention with [param] syntax in route directory names

Files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
src/lib/components/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use PascalCase for component file names and place them in src/lib/components/[feature]/ directory structure

Files:

  • src/lib/components/domains/nameserverTable.svelte
🧠 Learnings (3)
📓 Common learnings 
Learnt from: vermakhushboo
Repo: appwrite/console PR: 2364
File: src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte:52-89
Timestamp: 2025-09-24T10:27:36.797Z
Learning: In sites domain verification flows, domain creation should be handled in the background using promise chains (.then/.catch) with silent error handling, not awaited synchronously. This prevents domain creation failures from interrupting the main verification flow.
📚 Learning: 2025-09-24T10:27:36.797Z 
Learnt from: vermakhushboo
Repo: appwrite/console PR: 2364
File: src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte:52-89
Timestamp: 2025-09-24T10:27:36.797Z
Learning: In sites domain verification flows, domain creation should be handled in the background using promise chains (.then/.catch) with silent error handling, not awaited synchronously. This prevents domain creation failures from interrupting the main verification flow.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
📚 Learning: 2025-11-25T03:15:27.539Z 
Learnt from: CR
Repo: appwrite/console PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T03:15:27.539Z
Learning: Applies to src/routes/**/*.svelte : Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Applied to files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: e2e
🔇 Additional comments (8)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte (1)

28-29: LGTM!

The text now explicitly mentions "DNS changes," which improves clarity for users unfamiliar with the propagation delay context.

src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte (2)

14-20: AI summary describes features not present in this file.

The summary claims this file has a new domainsList prop, verified state, getApexDomain usage, and NameserverTable component integration. However, the actual code only contains show and selectedDomain props, and uses Table.Root directly without any apex-domain resolution logic.

Please verify whether the intended changes were applied to this file or if the summary is describing a different file (e.g., src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte).

67-68: LGTM!

The updated text provides clearer DNS-specific messaging about propagation timing.

src/lib/components/domains/nameserverTable.svelte (3)

6-14: LGTM!

Clean prop destructuring with proper TypeScript typing. The optional props with undefined defaults are appropriate for backward compatibility.

26-39: The ruleStatus === 'verified' case is not explicitly handled.

The badge logic handles 'created', 'verifying', and 'unverified' statuses, but 'verified' (which is a valid value per the type definition) falls through to rely solely on the verified boolean. If ruleStatus is 'verified' but the verified prop is false or not passed, no badge will render.

Is this intentional? If ruleStatus === 'verified' should display the "Verified" badge regardless of the verified prop, consider:

Suggested fix 
             {:else if ruleStatus === 'unverified'}
                 <Badge
                     variant="secondary"
                     type="error"
                     size="xs"
                     content="Certificate generation failed" />
-            {:else if verified === true}
+            {:else if ruleStatus === 'verified' || verified === true}
                 <Badge variant="secondary" type="success" size="xs" content="Verified" />
             {/if}

42-45: LGTM!

Text updated to be more DNS-specific, consistent with the messaging in other domain-related components.

src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/+page.svelte (2)

65-78: LGTM on apex domain error handling.

The error handling correctly allows the flow to continue when the apex domain already exists (domain_already_exists), while surfacing other errors to the user. This approach appropriately handles the case where the apex domain was previously added at the organization level.

61-61: > Likely an incorrect or invalid review comment.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

coderabbitai[bot]
coderabbitai bot reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)
src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte (1)

35-35: Potential null reference on nameservers property.

If domain.nameservers is null or undefined, calling .toLowerCase() will throw a runtime error. Consider adding a null check or using optional chaining.

Proposed fix 
-            if (domain.nameservers.toLowerCase() === 'appwrite') {
+            if (domain.nameservers?.toLowerCase() === 'appwrite') {
src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte (1)

45-47: Potential null reference error when from is null.

In SvelteKit's afterNavigate, from can be null (e.g., on initial page load or navigation from an external site). Accessing from.url when from is null will throw a TypeError. The optional chaining on url doesn't guard against from itself being null.

Suggested fix 
     afterNavigate(({ from }) => {
-        backPage = from.url?.pathname ?? `${base}/`;
+        backPage = from?.url?.pathname ?? `${base}/`;
     });
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte (1)

57-92: Invalidate caches before navigation.

Similar to the settings verify page, goto(routeBase) at line 81 executes before the cache invalidations at lines 82-83. Move the invalidations before navigation to ensure data is refreshed while the component is still mounted.

Suggested fix 
             verified = true;
             addNotification({
                 type: 'success',
                 message: 'Domain verified successfully'
             });

-            await goto(routeBase);
             await invalidate(Dependencies.DOMAINS);
             await invalidate(Dependencies.SITES_DOMAINS);
+            await goto(routeBase);
         } catch (error) {
🤖 Fix all issues with AI agents 
In
`@src/routes/`(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte:
- Around line 162-163: The NameserverTable component here is missing the
ruleStatus prop which other flows pass as ruleStatus={proxyRule.status}; update
the JSX inside the selectedTab === 'nameserver' branch to pass ruleStatus using
proxyRule.status (i.e., add ruleStatus={proxyRule.status} to the
<NameserverTable ... /> invocation) so the component receives consistent
proxyRule.status across all flows.
♻️ Duplicate comments (2)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte (1)

82-84: Invalidate calls after navigation may not execute reliably.

After await goto(routeBase) completes, the component may unmount and the subsequent invalidate calls might not run. Move the invalidations before navigation.

Suggested fix 
             addNotification({
                 type: 'success',
                 message: 'Domain verified successfully'
             });

+            await invalidate(Dependencies.DOMAINS);
+            await invalidate(Dependencies.FUNCTION_DOMAINS);
             await goto(routeBase);
-            await invalidate(Dependencies.DOMAINS);
-            await invalidate(Dependencies.FUNCTION_DOMAINS);
src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte (1)

57-91: Invalidate cache before navigation to ensure data consistency.

The goto(routeBase) at line 81 navigates away before invalidate(Dependencies.DOMAINS) at line 82 completes. This may cause the component to unmount before the cache is properly refreshed, leading to stale data on the target page.

Suggested fix 
             verified = true;
             addNotification({
                 type: 'success',
                 message: 'Domain verified successfully'
             });

-            await goto(routeBase);
             await invalidate(Dependencies.DOMAINS);
+            await goto(routeBase);
         } catch (error) {
🧹 Nitpick comments (3)
src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte (1)

47-49: Unsafe access to error message property.

In TypeScript, caught exceptions are typed as unknown. Accessing e.message directly without type checking can cause runtime errors if the thrown value isn't an Error object.

Proposed fix 
         } catch (e) {
-            error = e.message;
+            error = e instanceof Error ? e.message : 'An unexpected error occurred';
             trackError(e, Submit.DomainUpdateVerification);
         }
src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte (1)

4-4: Consolidate imports from the same module.

Both line 4 and line 12 import from $app/navigation. These should be merged into a single import statement.

Suggested fix 
-    import { goto } from '$app/navigation';
     import { Button, Form } from '$lib/elements/forms';
     import { InputDomain } from '$lib/elements/forms/index.js';
     import { Wizard } from '$lib/layout';
     import { addNotification } from '$lib/stores/notifications';
     import { sdk } from '$lib/stores/sdk';
     import { Divider, Fieldset, Layout } from '@appwrite.io/pink-svelte';
     import RecordsCard from '../recordsCard.svelte';
-    import { afterNavigate, invalidate } from '$app/navigation';
+    import { afterNavigate, goto, invalidate } from '$app/navigation';

Also applies to: 12-12

src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte (1)

85-92: Add type guard for error handling.

Accessing error.message directly assumes the caught value is an Error object. Consider using a type guard for safer error handling.

Suggested fix 
         } catch (error) {
             verified = false;
             isSubmitting.set(false);
             addNotification({
                 type: 'error',
-                message: error.message
+                message: error instanceof Error ? error.message : 'Verification failed'
             });
         }
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e93a775 and 5ed7bc5.

📒 Files selected for processing (10)
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/recordsCard.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/routes/(console)/organization-[organization]/domains/recordsCard.svelte
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx,js,jsx,svelte}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,svelte}: Import reusable modules from the src/lib directory using the $lib alias
Use minimal comments in code; reserve comments for TODOs or complex logic explanations
Use $lib, $routes, and $themes aliases instead of relative paths for module imports

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
src/routes/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
**/*.{ts,tsx,js,jsx,svelte,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use 4 spaces for indentation, single quotes, 100 character line width, and no trailing commas per Prettier configuration

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use Svelte 5 + SvelteKit 2 syntax with TypeScript for component development

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
src/routes/**

📄 CodeRabbit inference engine (AGENTS.md)

Configure dynamic routes using SvelteKit convention with [param] syntax in route directory names

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
🧠 Learnings (7)
📓 Common learnings 
Learnt from: vermakhushboo
Repo: appwrite/console PR: 2364
File: src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte:52-89
Timestamp: 2025-09-24T10:27:36.797Z
Learning: In sites domain verification flows, domain creation should be handled in the background using promise chains (.then/.catch) with silent error handling, not awaited synchronously. This prevents domain creation failures from interrupting the main verification flow.
📚 Learning: 2025-10-21T06:07:53.455Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2477
File: src/routes/(console)/project-[region]-[project]/overview/platforms/llmBanner.svelte:27-38
Timestamp: 2025-10-21T06:07:53.455Z
Learning: In the Appwrite Console codebase, the `copy` helper utility (src/lib/helpers/copy.ts) already handles errors internally with try-catch blocks and returns a boolean success indicator. Additional error handling with try-catch is not needed when calling this utility.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
📚 Learning: 2025-09-24T10:27:36.797Z 
Learnt from: vermakhushboo
Repo: appwrite/console PR: 2364
File: src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte:52-89
Timestamp: 2025-09-24T10:27:36.797Z
Learning: In sites domain verification flows, domain creation should be handled in the background using promise chains (.then/.catch) with silent error handling, not awaited synchronously. This prevents domain creation failures from interrupting the main verification flow.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
📚 Learning: 2025-12-05T09:24:15.846Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2670
File: src/routes/(console)/organization-[organization]/+layout.ts:134-150
Timestamp: 2025-12-05T09:24:15.846Z
Learning: In the Appwrite console codebase, `prefs.organization` is maintained to always reference an organization with Platform.Appwrite, so when using preferences.organization as a fallback in redirect logic, no additional platform validation is required.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
📚 Learning: 2025-10-13T05:13:54.542Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2413
File: src/routes/(console)/project-[region]-[project]/databases/table.svelte:33-39
Timestamp: 2025-10-13T05:13:54.542Z
Learning: In Svelte 5, `import { page } from '$app/state'` provides a reactive state proxy that can be accessed directly (e.g., `page.params`), unlike the older `import { page } from '$app/stores'` which returns a readable store requiring the `$page` syntax for auto-subscription in components.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
📚 Learning: 2025-11-25T03:15:27.539Z 
Learnt from: CR
Repo: appwrite/console PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T03:15:27.539Z
Learning: Applies to src/routes/**/*.svelte : Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Applied to files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
📚 Learning: 2025-10-13T05:16:07.656Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2413
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/header.svelte:54-58
Timestamp: 2025-10-13T05:16:07.656Z
Learning: In SvelteKit apps, shared layout components (like headers) that use `$derived(page.data.*)` should use optional chaining when accessing properties that may not be present on all routes. During page transitions, reactive statements can briefly evaluate with different page.data structures, so optional chaining prevents runtime errors when navigating between routes with different data shapes (e.g., between `/databases` and `/databases/database-[database]`).

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
🔇 Additional comments (11)
src/routes/(console)/organization-[organization]/domains/+page.svelte (1)

93-99: LGTM! Badge type change improves verification urgency.

Changing from "warning" to "error" for unverified domains appropriately emphasizes that verification is required for the domain to function correctly. This aligns with the broader PR objective of improving domain verification flows and consistency with other verification-related UI updates.

src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte (2)

14-20: AI summary describes props that are not present in the code.

The AI summary states this component adds domainsList?: Models.DomainsList to exported props and uses getApexDomain for apex domain resolution, but the actual code only has show and selectedDomain props with no domainsList or apex domain logic.

Please verify if these changes were intended but not implemented, or if the summary is outdated.

39-39: LGTM on text updates.

The updated notification message and DNS propagation instructions are clearer and more informative for users.

Also applies to: 67-68

src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte (1)

27-36: LGTM!

The flow correctly awaits cache invalidation before checking verification status, and navigates away only when the domain is auto-verified via Appwrite nameservers. This aligns with the PR objective of handling NS record flow and auto-verification.

src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte (2)

165-178: LGTM!

The child components NameserverTable and RecordTable are correctly receiving the ruleStatus prop from proxyRule.status, aligning with the refactored proxyRule-centric data flow.

57-69: LGTM - Silent error handling aligns with established patterns.

The silent catch for the nameserver update is appropriate here. Based on learnings, background operations like domain updates should use silent error handling to prevent failures from interrupting the main verification flow. The verification in the second try block proceeds regardless of nameserver update success.

src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte (3)

16-26: LGTM - Props and imports well structured.

The addition of getApexDomain import and optional domainsList prop aligns with the PR objective of handling NS record flow. The optional typing for domainsList is appropriate since it may not be available in all contexts.

52-65: Two-step verification pattern correctly implemented.

The first try-catch block for nameserver updates is appropriately non-blocking (silent failure), which aligns with the learning that domain-related operations should not interrupt the main verification flow. The bare catch syntax avoids the previously flagged variable shadowing issue.

67-88: LGTM - Main verification flow with proper cache invalidation.

The verification flow correctly:

  • Updates the selectedProxyRule with the response
  • Sets verified = true on success
  • Invalidates cache before closing the modal
  • Tracks analytics events appropriately
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte (1)

52-88: LGTM - Consistent implementation with functions modal.

The two-step verification flow mirrors the functions retryDomainModal correctly, using Dependencies.SITES_DOMAINS for the appropriate cache invalidation context. The bare catch block addresses the previously flagged variable shadowing issue.

src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte (1)

52-88: LGTM - Implementation consistent with other retry modals.

The verification flow and error handling patterns are consistent across all three retryDomainModal implementations (functions, sites, settings), using the appropriate dependency constant (Dependencies.DOMAINS) for cache invalidation in the settings context.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

coderabbitai[bot]
coderabbitai bot reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/lib/components/domains/recordTable.svelte (1)

1-172: Address Prettier formatting issue flagged by pipeline.

The CI pipeline indicates code style issues. Run npx prettier --write src/lib/components/domains/recordTable.svelte to fix formatting.

♻️ Duplicate comments (2)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte (2)

87-94: Add type guard for error access.

Same issue as in the sites version—accessing error.message directly can fail if the caught value is not an Error instance.

Suggested fix 
         } catch (error) {
             verified = false;
             isSubmitting.set(false);
             addNotification({
                 type: 'error',
-                message: error.message
+                message: error instanceof Error ? error.message : 'Verification failed'
             });
         }

103-103: URL-encode the domain parameter.

Same issue as in the sites version—the domain should be encoded to handle special characters.

Suggested fix 
-        await goto(`${routeBase}/add-domain?domain=${proxyRule.domain}`);
+        await goto(`${routeBase}/add-domain?domain=${encodeURIComponent(proxyRule.domain)}`);
🧹 Nitpick comments (2)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte (2)

86-93: Add type guard for error access.

Accessing error.message directly can fail if the caught value is not an Error instance (e.g., a thrown string or object).

Suggested fix 
         } catch (error) {
             verified = false;
             isSubmitting.set(false);
             addNotification({
                 type: 'error',
-                message: error.message
+                message: error instanceof Error ? error.message : 'Verification failed'
             });
         }

102-102: URL-encode the domain parameter.

If proxyRule.domain contains special characters (e.g., internationalized domains), the URL could break without proper encoding.

Suggested fix 
-        await goto(`${routeBase}/add-domain?domain=${proxyRule.domain}`);
+        await goto(`${routeBase}/add-domain?domain=${encodeURIComponent(proxyRule.domain)}`);
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe32cf7 and 5a8a15b.

📒 Files selected for processing (13)
  • src/lib/components/domains/recordTable.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/store.ts
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/table.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/store.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/routes/(console)/organization-[organization]/domains/add-domain/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/table.svelte
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{ts,tsx,js,jsx,svelte}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,svelte}: Import reusable modules from the src/lib directory using the $lib alias
Use minimal comments in code; reserve comments for TODOs or complex logic explanations
Use $lib, $routes, and $themes aliases instead of relative paths for module imports

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/store.ts
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/store.ts
  • src/lib/components/domains/recordTable.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

**/*.ts: Define types inline or in .d.ts files, avoid creating separate .types.ts files
Use TypeScript in non-strict mode; any type is tolerated in this project

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/store.ts
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/store.ts
**/*.{ts,tsx,js,jsx,svelte,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use 4 spaces for indentation, single quotes, 100 character line width, and no trailing commas per Prettier configuration

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/store.ts
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/store.ts
  • src/lib/components/domains/recordTable.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
src/routes/**

📄 CodeRabbit inference engine (AGENTS.md)

Configure dynamic routes using SvelteKit convention with [param] syntax in route directory names

Files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/store.ts
  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/store.ts
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
src/routes/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Files:

  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use Svelte 5 + SvelteKit 2 syntax with TypeScript for component development

Files:

  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/lib/components/domains/recordTable.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/organization-[organization]/domains/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
src/lib/components/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use PascalCase for component file names and place them in src/lib/components/[feature]/ directory structure

Files:

  • src/lib/components/domains/recordTable.svelte
🧠 Learnings (8)
📚 Learning: 2025-09-30T07:41:06.679Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2425
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte:454-468
Timestamp: 2025-09-30T07:41:06.679Z
Learning: In `src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte`, the column suggestions API (console.suggestColumns) has a maximum limit of 7 columns returned, which aligns with the initial placeholder count of 7 in customColumns.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/store.ts
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/store.ts
📚 Learning: 2025-09-24T10:27:36.797Z 
Learnt from: vermakhushboo
Repo: appwrite/console PR: 2364
File: src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte:52-89
Timestamp: 2025-09-24T10:27:36.797Z
Learning: In sites domain verification flows, domain creation should be handled in the background using promise chains (.then/.catch) with silent error handling, not awaited synchronously. This prevents domain creation failures from interrupting the main verification flow.

Applied to files:

  • src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
📚 Learning: 2025-10-13T05:16:07.656Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2413
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/header.svelte:54-58
Timestamp: 2025-10-13T05:16:07.656Z
Learning: In SvelteKit apps, shared layout components (like headers) that use `$derived(page.data.*)` should use optional chaining when accessing properties that may not be present on all routes. During page transitions, reactive statements can briefly evaluate with different page.data structures, so optional chaining prevents runtime errors when navigating between routes with different data shapes (e.g., between `/databases` and `/databases/database-[database]`).

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
📚 Learning: 2025-12-05T09:24:15.846Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2670
File: src/routes/(console)/organization-[organization]/+layout.ts:134-150
Timestamp: 2025-12-05T09:24:15.846Z
Learning: In the Appwrite console codebase, `prefs.organization` is maintained to always reference an organization with Platform.Appwrite, so when using preferences.organization as a fallback in redirect logic, no additional platform validation is required.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
📚 Learning: 2025-10-13T05:13:54.542Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2413
File: src/routes/(console)/project-[region]-[project]/databases/table.svelte:33-39
Timestamp: 2025-10-13T05:13:54.542Z
Learning: In Svelte 5, `import { page } from '$app/state'` provides a reactive state proxy that can be accessed directly (e.g., `page.params`), unlike the older `import { page } from '$app/stores'` which returns a readable store requiring the `$page` syntax for auto-subscription in components.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
  • src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte
📚 Learning: 2025-11-25T03:15:27.539Z 
Learnt from: CR
Repo: appwrite/console PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T03:15:27.539Z
Learning: Applies to src/routes/**/*.svelte : Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Applied to files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
📚 Learning: 2025-11-25T03:15:27.539Z 
Learnt from: CR
Repo: appwrite/console PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T03:15:27.539Z
Learning: Applies to src/lib/components/**/*.svelte : Use PascalCase for component file names and place them in src/lib/components/[feature]/ directory structure

Applied to files:

  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte
📚 Learning: 2025-10-21T06:07:53.455Z 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2477
File: src/routes/(console)/project-[region]-[project]/overview/platforms/llmBanner.svelte:27-38
Timestamp: 2025-10-21T06:07:53.455Z
Learning: In the Appwrite Console codebase, the `copy` helper utility (src/lib/helpers/copy.ts) already handles errors internally with try-catch blocks and returns a boolean success indicator. Additional error handling with try-catch is not needed when calling this utility.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
🪛 GitHub Actions: Tests
src/lib/components/domains/recordTable.svelte

[warning] 1-1: Code style issues found in the file. Run 'Prettier --write' to fix.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: e2e
🔇 Additional comments (23)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/store.ts (1)

4-26: LGTM!

The column width adjustments are straightforward configuration changes. Increasing the Domain column min width from 300 to 600 and Target column min width from 120 to 160 appear reasonable for accommodating the NS record flow and domain verification UI changes introduced in this PR.

src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/store.ts (1)

4-25: LGTM!

The column width adjustments are clean and follow the existing pattern. The increased minimum widths for the domain (300→600) and target (120→160) columns align with the broader UI updates for richer domain status presentation mentioned in the PR.

src/routes/(console)/organization-[organization]/domains/+page.svelte (1)

94-99: LGTM!

The badge styling changes appropriately escalate the visual severity for unverified domains from "warning" to "error", which better communicates the action needed. The size reduction to "xs" maintains visual consistency.

src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte (3)

29-54: LGTM - Clean retry verification flow.

The refactored retryDomain function has a clear flow:

  1. Reset error state
  2. Call updateNameservers API
  3. Invalidate relevant caches
  4. Check verification status and handle success/failure appropriately

The error handling properly surfaces the message and tracks the error for analytics.

14-20: AI summary does not match the actual code.

The AI summary claims this file has:

  • getApexDomain import
  • domainsList prop
  • NameserverTable and RecordTable components

However, the actual code only has show and selectedDomain props, and no such imports or components. This suggests the summary may be describing a different file with a similar name (perhaps in the settings or sites route).

69-72: LGTM - Helpful DNS propagation guidance.

The updated text appropriately sets user expectations about DNS propagation timing.

src/lib/components/domains/recordTable.svelte (1)

118-120: LGTM! Using InteractiveText for copyable subdomain improves UX consistency.

The Name column now aligns with the Value column's copy-to-clipboard pattern.

src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte (3)

57-91: Verification flow restructured appropriately with apex domain handling.

The two-step flow with silent nameserver update followed by rule verification aligns with the established pattern. Invalidation now correctly precedes navigation.

163-176: LGTM! NameserverTable and RecordTable now correctly receive ruleStatus.

Props are correctly passed from proxyRule.domain and proxyRule.status, consistent with other verify flows in the PR.

47-47: Critical: Cannot reassign a $derived value in Svelte 5.

Line 47 declares proxyRule as $derived(data.proxyRule), but line 73 attempts to reassign it. In Svelte 5, $derived creates a read-only computed property—reassignment will throw a runtime error.

Use $state with reactive initialization instead:

🐛 Proposed fix 
-    let proxyRule = $derived(data.proxyRule);
+    let proxyRule = $state(data.proxyRule);
+
+    $effect(() => {
+        proxyRule = data.proxyRule;
+    });

Alternatively, if local mutation isn't needed after successful verification (since we navigate away), consider keeping $derived and removing the reassignment at line 73.

Also applies to: 73-75

⛔ Skipped due to learnings 
Learnt from: ItzNotABug
Repo: appwrite/console PR: 2413
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/header.svelte:54-58
Timestamp: 2025-10-13T05:16:07.656Z
Learning: In SvelteKit apps, shared layout components (like headers) that use `$derived(page.data.*)` should use optional chaining when accessing properties that may not be present on all routes. During page transitions, reactive statements can briefly evaluate with different page.data structures, so optional chaining prevents runtime errors when navigating between routes with different data shapes (e.g., between `/databases` and `/databases/database-[database]`).
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte (2)

52-86: Two-step verification flow looks correct with proper error handling.

The apex domain resolution with silent nameserver update followed by rule verification follows the established pattern. Error state is properly managed with verified = false and user-facing error message.

134-148: LGTM! Child components correctly receive ruleStatus prop.

Both NameserverTable and RecordTable now pass ruleStatus={selectedProxyRule.status}, consistent with other modal implementations.

src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte (2)

52-86: Implementation consistent with sites retry modal pattern.

The two-step verification flow with apex domain handling, proper error state management, and correct dependency invalidation (Dependencies.DOMAINS for settings context) is well-structured.

134-148: LGTM! Props correctly passed to child table components.

src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte (2)

52-86: Verification flow correctly implements functions-specific handling.

Uses Dependencies.FUNCTION_DOMAINS for cache invalidation and the two-step apex domain + verification pattern is consistent with other retry modals.

134-148: LGTM! Correctly passes service="functions" to RecordTable.

Props are properly configured for the functions context.

src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte (4)

25-25: LGTM!

Import uses the $lib alias correctly per coding guidelines.

47-47: LGTM!

The derived state pattern is appropriate here. The reassignment after verification (line 73) updates local state before navigation, which is acceptable since navigation follows immediately.

60-70: LGTM!

Silent error handling for the nameserver update is intentional—per learnings, this prevents nameserver failures from interrupting the main verification flow.

166-179: LGTM!

Props correctly pass domain and ruleStatus from the derived proxyRule state to child components.

src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte (3)

25-25: LGTM!

Import correctly uses the $lib alias per coding guidelines.

73-86: Invalidation order is now correct.

The invalidation calls (lines 78-81) now occur before navigation (line 82), addressing the concern from the previous review about invalidate calls potentially not executing after component unmount.

167-180: LGTM!

Props correctly pass domain and ruleStatus from the derived proxyRule state to child components.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

ItzNotABug
ItzNotABug requested changes Jan 14, 2026
View reviewed changes
@hmacr hmacr merged commit 36f5ba4 into main Jan 14, 2026
3 checks passed
@hmacr hmacr deleted the ser-720 branch January 14, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ItzNotABug ItzNotABug ItzNotABug approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmacr @ItzNotABug