ThreadTask: fix thread lifetime ordering and make detach flag atomic #3662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change: Reorder ThreadTask data members so std::thread is destroyed last, ensuring all members accessed by the running thread remain valid during shutdown. Also make the detach flag atomic to avoid potential data races between the executor thread and the owning thread. Reason: This change improves thread-safety and prevents subtle undefined behavior without modifying the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
This PR improves the thread-safety and lifetime correctness of
ThreadTask.Changes include:
std::threadis destroyed last, ensuring allmembers accessed by the worker thread remain valid during destruction.
m_detachedtostd::atomic<bool>to prevent data races whenaccessed concurrently by multiple threads.
order and using a lambda for thread startup for improved clarity.
These changes do not modify the public API and are purely internal
correctness and safety improvements.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.