Generate CompleteMultipartUpload #4209

peterrsongg · 2025-12-09T01:46:45Z

Stacked PRs:

Description

Generates CompleteMultipartUpload

Before in s3.customizations.json we were excluding MultipartUpload and injecting PartETags. Since s3 was not generated, this change didn't really matter. This would only matter when we generate the simple methods for an operation from the s3.customizations.simpleforms.json but in this case there is no simple method that has PartETags as a param. The issue with this approach is that if the service team updates MultipartUpload and adds member, the now generated S3 will miss this update. Instead, we take the correct approach which is to flatten MultipartUpload so that its members are added to the top-level shape. This way, any updates to MultipartUpload are generated as well.

Assembly Comparison Output (MpuObject size changed to a nulalble int) will call this out in changelog

AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.CompleteMultipartUploadRequest/MethodRemoved: Missing method System.Int64 get_MpuObjectSize() in Amazon.S3.Model.CompleteMultipartUploadRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CompleteMultipartUploadRequest/MethodAdded: New method System.Nullable<System.Int64> get_MpuObjectSize() in Amazon.S3.Model.CompleteMultipartUploadRequest
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.CompleteMultipartUploadRequest/MethodRemoved: Missing method System.Void set_MpuObjectSize(System.Int64) in Amazon.S3.Model.CompleteMultipartUploadRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CompleteMultipartUploadRequest/MethodAdded: New method System.Void set_MpuObjectSize(System.Nullable<System.Int64>) in Amazon.S3.Model.CompleteMultipartUploadRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.CompletedMultipartUpload/TypeAdded: New type Amazon.S3.Model.CompletedMultipartUpload

Motivation and Context

Testing

DRY RUN: DRY_RUN-e581806f-264b-46d0-a331-1318e27c2273

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My code follows the code style of this project
My change requires a change to the documentation
I have updated the documentation accordingly
I have read the README document
I have added tests to cover my changes
All new and existing tests passed

License

I confirm that this pull request can be released under the Apache 2 license

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

...Generated/Model/Internal/MarshallTransformations/CompleteMultipartUploadRequestMarshaller.cs

generator/ServiceModels/s3/s3.customizations.json

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

dscpinheiro · 2025-12-23T00:54:01Z

...Generated/Model/Internal/MarshallTransformations/CompleteMultipartUploadRequestMarshaller.cs

+                                xmlWriter.WriteElementString("PartNumber", StringUtils.FromInt(publicRequestPartETagsValue.PartNumber.Value));
+                            xmlWriter.WriteEndElement();
+                        }
+                        }            


I know I'm being annoying, but after we're done generating S3 we should really fix the indentation in these classes...

No worries, I'll backlog it for now as an LHF and open a separate PR to fix the spacing

ended up just fixing it here:

#4256

dscpinheiro · 2025-12-23T00:54:31Z

...S3/Custom/Model/Internal/MarshallTransformations/CompleteMultipartUploadRequestMarshaller.cs

-
-            var stringWriter = new XMLEncodedStringWriter(System.Globalization.CultureInfo.InvariantCulture);
-            using (var xmlWriter = XmlWriter.Create(stringWriter, new XmlWriterSettings() { Encoding = Encoding.UTF8, OmitXmlDeclaration = true, NewLineHandling = NewLineHandling.Entitize }))
+            if (publicRequest.PartETags != null && (publicRequest.PartETags.Count > 0 || !AWSConfigs.InitializeCollections))


Could use IsSet here now, right?

yup, rebased on dev and ran the generator so that this uses the IsSet methods.

dscpinheiro · 2025-12-23T01:00:48Z

sdk/src/Services/S3/Generated/Model/CompletedMultipartUpload.cs

+    /// <summary>
+    /// The container for the completed multipart upload details.
+    /// </summary>
+    public partial class CompletedMultipartUpload


Where is this class used? I don't see it referenced in the request or response... The request has its own private List<PartETag> _partETags field.

It actually isn't used anywhere at the moment, since the custom code had flattened this shape and moved it up to the response.

We could remove it altogether by including it in the excludeShapes array, but I left it in on purpose in the off chance that this shape is used in another operation later down the line. If another operation were to use this shape then the generator would fail at runtime.

stack-info: PR: #4206, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/3

stack-info: PR: #4207, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/4

stack-info: PR: #4208, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/5

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

peterrsongg force-pushed the peterrsongg/petesong/phase-3-pr5-rebased-2/5 branch from 108e71e to 925e059 Compare December 9, 2025 01:47

peterrsongg force-pushed the peterrsongg/petesong/phase-3-pr5-rebased-2/6 branch from 8302e87 to 749a49d Compare December 9, 2025 01:47

peterrsongg added a commit that referenced this pull request Dec 9, 2025

Generate CompleteMultipartUpload

ea64644

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

peterrsongg requested a review from muhammad-othman December 9, 2025 17:29

peterrsongg marked this pull request as ready for review December 9, 2025 17:29

dscpinheiro reviewed Dec 11, 2025

View reviewed changes

...Generated/Model/Internal/MarshallTransformations/CompleteMultipartUploadRequestMarshaller.cs Outdated Show resolved Hide resolved

generator/ServiceModels/s3/s3.customizations.json Show resolved Hide resolved

peterrsongg added a commit that referenced this pull request Dec 12, 2025

Generate CompleteMultipartUpload

b3bbcaf

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

peterrsongg added a commit that referenced this pull request Dec 12, 2025

Generate CompleteMultipartUpload

71cc1d8

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

peterrsongg changed the base branch from peterrsongg/petesong/phase-3-pr5-rebased-2/5 to petesong/phase-3-pr5-base December 12, 2025 18:16

peterrsongg force-pushed the peterrsongg/petesong/phase-3-pr5-rebased-2/6 branch from 749a49d to 71cc1d8 Compare December 12, 2025 18:24

This was referenced Dec 12, 2025

Generate DeleteBucketMetadataConfiguration #4204

Merged

Generate ListObjects #4205

Merged

Generate UpdateBucketMetadataTableConfiguration #4206

Merged

generate ListMultipartUploads #4207

Merged

generate RestoreObject #4208

Open

peterrsongg changed the base branch from petesong/phase-3-pr5-base to peterrsongg/petesong/phase-3-pr5-rebased-2/5 December 12, 2025 18:25

peterrsongg added a commit that referenced this pull request Dec 15, 2025

Generate CompleteMultipartUpload

3e389b3

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

peterrsongg added a commit that referenced this pull request Dec 19, 2025

Generate CompleteMultipartUpload

74d8f47

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

peterrsongg requested a review from dscpinheiro December 22, 2025 19:00

peterrsongg added a commit that referenced this pull request Dec 23, 2025

Generate CompleteMultipartUpload

167ec2a

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

dscpinheiro reviewed Dec 23, 2025

View reviewed changes

peterrsongg force-pushed the peterrsongg/petesong/phase-3-pr5-rebased-2/5 branch from 49dfa8b to 5c80909 Compare December 23, 2025 05:53

peterrsongg added 6 commits December 22, 2025 23:22

Fix merge conflicts, re-run generator after rebase

b8da6c9

Generate UpdateBucketMetadataTableConfiguration

c47528c

stack-info: PR: #4206, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/3

generate ListMultipartUploads

d713103

stack-info: PR: #4207, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/4

generate RestoreObject

1752308

stack-info: PR: #4208, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/5

Generate CompleteMultipartUpload

f0c6759

stack-info: PR: #4209, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/6

fix merge conflicts, rebase on development, re-run generator

255c1bf

peterrsongg force-pushed the peterrsongg/petesong/phase-3-pr5-rebased-2/6 branch from 71cc1d8 to 255c1bf Compare December 23, 2025 07:39

peterrsongg requested a review from dscpinheiro December 23, 2025 07:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Generate CompleteMultipartUpload #4209

Generate CompleteMultipartUpload #4209

peterrsongg commented Dec 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

dscpinheiro Dec 23, 2025

Uh oh!

peterrsongg Dec 23, 2025

Uh oh!

peterrsongg Dec 23, 2025

Uh oh!

dscpinheiro Dec 23, 2025

Uh oh!

peterrsongg Dec 23, 2025

Uh oh!

dscpinheiro Dec 23, 2025

Uh oh!

peterrsongg Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Generate CompleteMultipartUpload #4209

Are you sure you want to change the base?

Generate CompleteMultipartUpload #4209

Conversation

peterrsongg commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

Checklist

License

Uh oh!

Uh oh!

Uh oh!

dscpinheiro Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

peterrsongg Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

peterrsongg Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

dscpinheiro Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

peterrsongg Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

dscpinheiro Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

peterrsongg Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

peterrsongg commented Dec 9, 2025 •

edited

Loading