-
Notifications
You must be signed in to change notification settings - Fork 571
Add Spring Boot 4.0 support with working samples #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bnusunny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Please check the two comments I left.
d7dd038 to
52fedb7
Compare
80b787b to
a5a34b5
Compare
a5a34b5 to
b83323f
Compare
| <dependency> | ||
| <groupId>com.amazonaws.serverless</groupId> | ||
| <artifactId>aws-serverless-java-container-core</artifactId> | ||
| <version>${project.version}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how this worked, but if it was this sort of variable ${project.version} we might want to keep it like that, so it's easier in the future to update? (unless there's a reason to not do it, and it should be mentioned in the PR description)
(same in other pom.xml files).
| | Version | Branch | Java Enterprise support | Spring versions | JAX-RS/ Jersey version | Struts support | Spark support | | ||
| |---------|--------|-----------------------------|-----------------|------------------------|----------------|---------------| | ||
| | 1.x | [1.x](https://github.com/aws/serverless-java-container/tree/1.x) | Java EE (javax.*) | 5.x (Boot 2.x) | 2.x | :white_check_mark: | :white_check_mark: | | ||
| | 2.x | [main](https://github.com/aws/serverless-java-container/tree/main) | Jakarta EE 9-10 (jakarta.*) | 6.x (Boot 3.x) | 3.x | :x: | :x: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to create a "2.x" branch from the current main branch for SpringBoot3 support. And update the branch name here.
| Follow the quick start guides in [our wiki](https://github.com/aws/serverless-java-container/wiki) to integrate Serverless Java Container with your project: | ||
| * [Spring quick start](https://github.com/aws/serverless-java-container/wiki/Quick-start---Spring) | ||
| * [Spring Boot 2 quick start](https://github.com/aws/serverless-java-container/wiki/Quick-start---Spring-Boot2) | ||
| * [Spring Boot 3 quick start](https://github.com/aws/serverless-java-container/wiki/Quick-start---Spring-Boot3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a Spring Boot 4 quick start
| <artifactId>aws-serverless-java-container</artifactId> | ||
| <groupId>com.amazonaws.serverless</groupId> | ||
| <version>2.1.5-SNAPSHOT</version> | ||
| <version>2.1.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest 2.x version is 2.1.5. We should use the latest 2.x version here.
| <groupId>com.amazonaws.serverless</groupId> | ||
| <artifactId>aws-serverless-java-container-core</artifactId> | ||
| <version>2.1.5-SNAPSHOT</version> | ||
| <version>2.1.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 2.1.5
| <groupId>com.amazonaws.serverless</groupId> | ||
| <artifactId>aws-serverless-java-container-core</artifactId> | ||
| <version>2.1.5-SNAPSHOT</version> | ||
| <version>2.1.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 2.1.5 too
| <groupId>com.amazonaws.serverless</groupId> | ||
| <artifactId>aws-serverless-java-container</artifactId> | ||
| <version>2.1.5-SNAPSHOT</version> | ||
| <version>2.1.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 2.1.5
| <groupId>com.amazonaws.serverless.archetypes</groupId> | ||
| <artifactId>aws-serverless-springboot3-archetype</artifactId> | ||
| <version>2.1.5-SNAPSHOT</version> | ||
| <version>2.1.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 2.1.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README said this sample is for x86 architecture. We should not change this.
Issue #, if available:
Description of changes:
By submitting this pull request