Remove emit_swiftinterface from the Apple rule transitions.
#2628
Conversation
AttilaTheFun
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
AttilaTheFun
force-pushed
the
master
branch
2 times, most recently
from
b1e0430 to
8384c24
Compare
|
Hmm, this is a breaking change, right? |
Instead of relying on the transition to set the flag throughout the dependency graph, users should set `library_evolution = True` on the specific libraries that they want to support library evolution. PiperOrigin-RevId: 629760009 (cherry picked from commit 24a862d)
|
@brentleyjones You already cherry-picked the removal of the build config from rules_swift, so the head of rules_apple is now incompatible with the head of rules_swift without this change. We either need to revert the change in rules_swift, or apply this change to rules_apple from upstream. |
|
Sure, we need this, but I'm wondering if it means a 4.0 version bump. |
|
How do you view what counts as a breaking change? If we cut a new version of rules_apple for this, I'd argue we'd need a new version of rules_swift, too. It was actually that breakage that necessitated this one. |
If people upgrade to a version of rules_apple that have this change and it breaks their builds. |
|
@AttilaTheFun looks like there are some test failures that need to be fixed before we can land this |
5 participants
Instead of relying on the transition to set the flag throughout the dependency graph, users should set
library_evolution = Trueon the specific libraries that they want to support library evolution.PiperOrigin-RevId: 629760009
(cherry picked from commit 24a862d)